fix(dashboards): disable timeseries explain when AI is disabled - #9646
Merged
Conversation
The explain anomaly feature opens the dashboard AI chat, so it should be hidden when the `ai` feature flag is off. Add `ai` to the explain enablement store and wire it into the ExplainButton render and the `E` keyboard shortcut, which were previously ungated after the store's wiring was dropped in an earlier refactor.
Collaborator
Author
|
@codex: review |
|
Codex Review: Didn't find any major issues. Another round soon, please! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
AdityaHegde
approved these changes
Jul 6, 2026
nishantmonu51
added
Type:Bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
aifeature flag: when AI is disabled, both the on-chart "Explain (E)" button and theEkeyboard shortcut are hidden.aitomeasureSelection.getEnabledStore()and wires that store intoExplainButton(MeasureChartBody.svelte) and the key handler (ChartInteractions.svelte). The store was purpose-built to gate explain but had become unused after an earlierMeasureChartrefactor, so explain was rendering ungated.dashboardChat && exploreNameconditions only hides explain where it is already non-functional (embeds and the explore editor); normal cloud dashboards are unaffected sincedashboard_chatdefaults to true there.Checklist:
Developed in collaboration with Claude Code