Skip to content

Fix nil-pointer panic in ai resolver when time_range/comparison_time_range are omitted #9703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nishantmonu51 merged 1 commit into from
Jul 20, 2026
+10 −2
Merged

Fix nil-pointer panic in ai resolver when time_range/comparison_time_range are omitted #9703

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions runtime/resolvers/ai.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,11 +75,19 @@ func newAI(ctx context.Context, opts *runtime.ResolverOptions) (runtime.Resolver
return nil, errors.New("prompt is required for non-report AI sessions")
}

if props.TimeRange != nil && (props.TimeRange.IsoDuration != "" || props.TimeRange.IsoOffset != "") {
// Default omitted time ranges to empty values, which resolveTimeRange treats as a no-op.
if props.TimeRange == nil {
props.TimeRange = &metricsview.TimeRange{}
}
if props.ComparisonTimeRange == nil {
props.ComparisonTimeRange = &metricsview.TimeRange{}
}

if props.TimeRange.IsoDuration != "" || props.TimeRange.IsoOffset != "" {
return nil, errors.New("iso_duration and iso_offset are deprecated in favor of rilltime expressions")
}

if props.ComparisonTimeRange != nil && (props.ComparisonTimeRange.IsoDuration != "" || props.ComparisonTimeRange.IsoOffset != "") {
if props.ComparisonTimeRange.IsoDuration != "" || props.ComparisonTimeRange.IsoOffset != "" {
return nil, errors.New("iso_duration and iso_offset are deprecated in favor of rilltime expressions")
}

Expand Down
Loading