Skip to content

fix: ListResources failing for projects with large number of resources#9727

Merged
k-anshul merged 4 commits into
mainfrom
list_resources_paginate
Jul 23, 2026
Merged

fix: ListResources failing for projects with large number of resources#9727
k-anshul merged 4 commits into
mainfrom
list_resources_paginate

Conversation

@k-anshul

@k-anshul k-anshul commented Jul 22, 2026

Copy link
Copy Markdown
Member

Issue:

Saw error, failed to list resources: rpc error: code = ResourceExhausted desc = grpc: received message larger than max (5440191 vs. 4194304) (ResourceExhausted)when running rill project status project for a project with huge number of resources(500+ explore dashboards and metrics views).

  • The current PR just introduces pagination in CLI command to fix immediate API failure. UI changes (if required) can be taken up separately.
  • The controller still copies and returns the full list and pagination is done in API handler. The controller changes can be done in follow ups.
  • The CLI command still prints full resources and no pagination is introduced.

Checklist:

  • Covered by tests
  • Ran it and it works as intended
  • Reviewed the diff before requesting a review
  • Checked for unhandled edge cases
  • Linked the issues it closes
  • Checked if the docs need to be updated. If so, create a separate Linear DOCS issue
  • Intend to cherry-pick into the release branch
  • I'm proud of this work!

@k-anshul k-anshul self-assigned this Jul 22, 2026
@k-anshul k-anshul changed the title List resources paginate fix: ListResources failing for projects with large number of resources Jul 22, 2026
@nishantmonu51 nishantmonu51 added Type:Bug Something isn't working Size:M Medium change: 100-499 lines labels Jul 23, 2026
string path = 3;
// Skip security checks
bool skip_security_checks = 4;
// Maximum number of resources to return. If zero, returns all resources.

@k-anshul k-anshul Jul 23, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If zero, returns all resources.

Kept it for compatibility in UI and older CLI.

@k-anshul
k-anshul marked this pull request as ready for review July 23, 2026 05:18
@k-anshul
k-anshul requested a review from begelundmuller July 23, 2026 05:18

@begelundmuller begelundmuller left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Agree on just fixing the issue at the API level for now.

@k-anshul
k-anshul merged commit 943e3d0 into main Jul 23, 2026
13 of 14 checks passed
k-anshul added a commit that referenced this pull request Jul 23, 2026
#9727)

* fix: ListResources failing for projects with large number of resources

* fix: ListResources failing for projects with large number of resources

* review

* also sort the final result
@k-anshul
k-anshul deleted the list_resources_paginate branch July 23, 2026 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Size:M Medium change: 100-499 lines Type:Bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants