fix: use DI for DistributedLockService Redis client (fixes #818)#1064
Merged
Conversation
|
@menawar Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
Well done on the job done so far! |
Contributor
Author
thank you @RUKAYAT-CODER conflicts resolved |
Contributor
|
Always pull from main before pushing. |
Contributor
|
Thank you for contributing to the project. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR addresses issue #818 by replacing the inline
new Redis()instantiation inDistributedLockServicewith NestJS Dependency Injection. This prevents connection leaks on module teardown and improves testability by allowing a mocked client to be passed during unit testing.Changes
OrchestrationModulewhich defines aDISTRIBUTED_LOCK_REDISprovider using the shared Redis factory.@Inject(DISTRIBUTED_LOCK_REDIS)).OnModuleDestroylifecycle hook to explicitly close the Redis connection (this.redis.quit()) during module teardown.distributed-lock.service.spec.tsto pass a mocked Redis client instead of relying on the previously hardcodedRedisclass instance.OrchestrationModule.Fixes #818