fix: eliminate version number race in CoursesService.update - #1119
Merged
RUKAYAT-CODER merged 1 commit intoJul 28, 2026
Merged
Conversation
Add unique composite constraint on (courseId, versionNumber) and compute the next version inside a transaction with SELECT ... FOR UPDATE to serialize concurrent edits. - Migration: resolves existing duplicates and creates unique index - Entity: names the unique index for consistency - Service: uses DataSource.transaction + pessimistic lock + retry on unique violation across update, rollbackToVersion, and create - Tests: concurrency test validates sequential versions 2 and 3; retry test validates transparent recovery from unique violation Closes rinafcode#1009
|
@Chinonso-Peter Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
Author
|
@RUKAYAT-CODER please review |
Contributor
|
Thank you for contributing to the project |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add unique composite constraint on (courseId, versionNumber) and compute the next version inside a transaction with SELECT ... FOR UPDATE to serialize concurrent edits.
Closes #1009