Fix/qrcode layout shift - #1004
Merged
RUKAYAT-CODER merged 2 commits intoJul 27, 2026
Merged
Conversation
|
@dominiccreates Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
Thank you for contributing to the project. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #973
This PR addresses an issue in src/components/QRCode.tsx where the outer render wrapper failed to reserve space prior to the canvas painting, causing unwanted layout shifting. Additionally, it optimizes how the component queries for the canvas element.
Key Changes:
Reserved Wrapper Dimensions: Added explicit width and height styling to the actual render wrapper (div), matching the fallback UI, to ensure the space is fully reserved before the QR canvas has painted.
Optimized onRender Canvas Query: Modified the useEffect hook to prevent it from re-querying the canvas redundantly on every color or size prop change. The dependency array was streamlined to only re-query when !!value flips (i.e. mount/unmount and when valid URL inputs toggle), reducing unnecessary DOM operations.