refactor(courses): memoize DiscountProgressBar tier scans and derived…#994
Merged
Conversation
|
@chuks68 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
Thank you for contributing to the project. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #987 This PR optimizes rendering performance and aligns the threshold evaluation logic within the DiscountProgressBar component (
DiscountProgressBar.tsx
).
Key Changes
Memoized All Derived Properties:
Wrapped maxThreshold, normalizedSpend, progressPercent, amountToNext, and allUnlocked within useMemo hooks to avoid redundant recalculations on every render.
Consistent Threshold Comparisons:
Updated the tier markers and tier list items to check whether they are unlocked using the memoized normalizedSpend rather than using the raw currentSpend value directly.
Memoized Tier Scans:
Extracted the mapping of DISCOUNT_TIERS and the evaluation of whether a tier is unlocked into a new useMemo block called memoizedTiers. The JSX now loops over this pre-computed list, avoiding scanning and calculation overhead during renders.
Verification Results
Automated Tests
Both unit and integration tests were executed successfully:
Unit Tests: src/components/courses/tests/DiscountProgressBar.test.tsx (5 tests passed)
Integration Tests: src/components/courses/tests/EnrollmentCTA.integration.test.tsx (1 test passed)
bash
✓ src/components/courses/tests/DiscountProgressBar.test.tsx (5 tests) 136ms
✓ src/components/courses/tests/EnrollmentCTA.integration.test.tsx (1 test) 79ms