Skip to content

Return nil when getting resource response for directory entry#97

Merged
weavejester merged 1 commit intoring-clojure:masterfrom
dm3:directory-entry-resource-response
Oct 20, 2013
Merged

Return nil when getting resource response for directory entry#97
weavejester merged 1 commit intoring-clojure:masterfrom
dm3:directory-entry-resource-response

Conversation

@dm3
Copy link
Copy Markdown

@dm3 dm3 commented Oct 19, 2013

Fixes #96

@weavejester
Copy link
Copy Markdown
Member

Thanks for the patch! Could you remove the "fix(url-response: " prefix from your commit messages? When the commit is merged, the merge commit will contain information grouping the commits.

@technomancy
Copy link
Copy Markdown

It would be great to get this into a bugfix release soon; it's going to affect a lot of users as they upgrade to the latest version of Leiningen which fixes the leaving-directories-out-of-jars behaviour.

@dm3
Copy link
Copy Markdown
Author

dm3 commented Oct 19, 2013

Commits merged and renamed as requested.

weavejester added a commit that referenced this pull request Oct 20, 2013
Return nil when getting resource response for directory entry
@weavejester weavejester merged commit 02863f4 into ring-clojure:master Oct 20, 2013
@weavejester
Copy link
Copy Markdown
Member

I'll release this into version 1.2.1 soon.

@technomancy
Copy link
Copy Markdown

Fantastic; thank you.

@jinze
Copy link
Copy Markdown

jinze commented Oct 31, 2013

ring-server and lein-ring also need to be update

@weavejester
Copy link
Copy Markdown
Member

Yep, but you can always override the dependencies in your own project file to point to the newest version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

wrap-resource is broken in JARs created with Leiningen 2.3.3

4 participants