Skip to content

Accept Content-Encoding values case-insensitive - #354

Merged
botic merged 1 commit into
ringo:masterfrom
grob:httpclient-content-encoding
Oct 3, 2016
Merged

Accept Content-Encoding values case-insensitive#354
botic merged 1 commit into
ringo:masterfrom
grob:httpclient-content-encoding

Conversation

@grob

@grob grob commented Oct 2, 2016

Copy link
Copy Markdown
Member

According to the spec the value of the content-encoding header field
is case insensitive, therefor changed readResponse() to utilize
equalsIgnoreCase() when checking the content encoding.

See https://www.w3.org/Protocols/rfc2616/rfc2616-sec3.html#sec3.5

According to the spec the value of the content-encoding header field
is case insensitive, therefor changed `readResponse()` to utilize
`equalsIgnoreCase()` when checking the content encoding.

See https://www.w3.org/Protocols/rfc2616/rfc2616-sec3.html#sec3.5
@mention-bot

Copy link
Copy Markdown

@grob, thanks for your PR! By analyzing the history of the files in this pull request, we identified @hns, @botic and @kmfdm1 to be potential reviewers.

@botic
botic merged commit 0ffad94 into ringo:master Oct 3, 2016
@botic

botic commented Oct 3, 2016

Copy link
Copy Markdown
Member

Thx for the PR!

@grob
grob deleted the httpclient-content-encoding branch October 3, 2016 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants