Added csr_definitions

[james-ball-qualcomm]

No description provided.

[Copilot]

Pull request overview

This PR extends the params-generation pipeline to support a new csr_definitions section in param definition YAML, producing a csrs collection in the generated params JSON/HTML output and updating schemas/tests accordingly.

Changes:

• Add CSR ingestion (csr_definitions) in tools/create_params.py, emitting csrs entries and rendering CSR tables/links in HTML output.
• Update feature rendering fallback to prefix chapter-based features with CHAP: for clearer display.
• Extend JSON schemas to describe csr_definitions inputs and csrs outputs; update golden test fixtures and a Makefile loop.

Reviewed changes

Copilot reviewed 15 out of 15 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
tools/shared_utils.py	Changes feature formatting fallback to CHAP:<chapter> when no impl-def-derived features exist.
tools/create_params.py	Adds CSR parsing/output, HTML sidebar/table rendering for CSRs, and generalizes impl-def error messaging.
tests/params/test-ch2.yaml	Adds csr_definitions test input.
tests/params/expected/test-params.json	Updates expected params JSON to include csrs.
tests/params/expected/test-params.html	Updates expected HTML to include CSR sidebar section and CSR table(s).
tests/params/expected/test-param-table-variants/**/ROSE_COLORS.adoc	Updates expected AsciiDoc fragments due to CHAP: feature formatting.
tests/params/expected/test-param-appendix-adoc-includes/test-ch2/ROSE_COLORS.adoc	Updates expected AsciiDoc include output due to CHAP: feature formatting.
tests/norm-rule/test-ch2.yaml	Adjusts normative rule fixtures to support CSR field rules and alters ROSE_COLORS fixture.
tests/norm-rule/expected/test-norm-rules.json	Updates expected normative-rules JSON output to reflect fixture changes.
tests/norm-rule/expected/test-norm-rules.html	Updates expected normative-rules HTML output to reflect fixture changes.
schemas/params-schema.json	Adds csrs output schema and loosens top-level required keys via anyOf.
schemas/param-defs-schema.json	Adds csr_definitions input schema and loosens required keys via anyOf.
schemas/param-common-schema.json	Adds csrType enum used by the new CSR output schema.
Makefile	Replaces a shell for loop with a $(foreach ...) expansion for param-table variants generation.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.