Add merged param csr table#241
Merged
james-ball-qualcomm merged 6 commits intomainfrom Apr 1, 2026
Merged
Conversation
Signed-off-by: James Ball <jameball@qti.qualcomm.com>
Signed-off-by: James Ball <jameball@qti.qualcomm.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR consolidates the parameter-appendix and CSR-appendix AsciiDoc generation flow into a single “merged tables” workflow, updating the build/test harness and golden outputs accordingly.
Changes:
- Replace the separate
create_param_appendix.py/create_csr_appendix.pytooling with a unifiedcreate_param_tables.pyworkflow (docs + build wiring). - Update the Makefile test pipeline to generate/compare the new merged output directory and top-level include files.
- Refresh test inputs and expected AsciiDoc fragments (including table-variant goldens) to match the new output structure and naming.
Reviewed changes
Copilot reviewed 108 out of 266 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| tools/README.md | Updates tool inventory and documents the new merged parameter/CSR table generator and its outputs. |
| tools/create_param_appendix.py | Removed legacy parameter-only appendix generator script. |
| tools/create_csr_appendix.py | Removed legacy CSR-only appendix generator script. |
| Makefile | Rewires test/build targets to use the merged table generator and new expected output locations; removes CSR-adoc build/compare targets. |
| tests/params/test-param-tables.adoc | New test wrapper that includes both parameter and CSR generated tables. |
| tests/params/test-param-appendix.adoc | Removed old parameter-only test wrapper. |
| tests/params/test-csr-appendix.adoc | Removed old CSR-only test wrapper. |
| tests/params/expected/test-param-tables.adoc | Adds expected wrapper for the merged param+CSR table output. |
| tests/params/expected/test-param-tables/** | Adds/updates golden AsciiDoc fragments and include files for merged chapter-local params/ + csrs/ structure and top-level all_params*.adoc. |
| tests/params/expected/test-param-table-variants/** | Updates parameter table variant golden outputs to the new chapter-local params/ layout and top-level naming. |
| tests/params/expected/test-csr-table-variants/** | Updates CSR table variant golden outputs to the new chapter-local csrs/ layout and top-level naming. |
| tests/params/expected/test-csr-appendix.adoc | Updates expected CSR wrapper includes to match the merged tool’s top-level filenames. |
| tests/params/expected/test-param-appendix.adoc | Removes obsolete expected parameter-only wrapper. |
| tests/params/expected/test-param-appendix-adoc-includes/** | Updates legacy expected CSR include artifacts (still present in-tree) to match current output naming/ordering. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: James Ball <jameball@qti.qualcomm.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: James Ball <jameball@qti.qualcomm.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: James Ball <jameball@qti.qualcomm.com>
… README Agent-Logs-Url: https://github.com/riscv/docs-resources/sessions/8bd9f065-446f-4366-a8dc-ae204a79db5d Co-authored-by: james-ball-qualcomm <140646808+james-ball-qualcomm@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.