correctionlib: add build-correctionlib.yml for riscv64 wheels - #1107
Merged
Conversation
Standard sdist-then-cibuildwheel port of the pybind11 correction-factor library (vendored pybind11/rapidjson/cpp-peglib/pcg-cpp/xxhash/lwtnn submodules). Drops musllinux (no riscv64 numpy wheel), narrows the test group to skip awkward/dask-awkward (their awkward-cpp dependency has no riscv64 wheel published yet), and builds but does not test cp314t (pandas and scipy publish no cp314t wheel on any platform yet).
…t dep CIBW_TEST_REQUIRES adds to, not replaces, pyproject's test-groups, so the full upstream `test` group (including awkward/dask-awkward) was still installed alongside it. Clear it with CIBW_TEST_GROUPS: ''. Also drop uproot, which pulls in cramjam (no riscv64 wheel, fails cross-compiling from source) and which no test here actually imports. Restore upstream's own PIP_ONLY_BINARY so a similar gap fails fast instead of attempting a multi-hour source build.
…gence) test_lwtnn_example asserts exact float equality on a lwtnn/Eigen neural-network evaluation and diverges from riscv64 at the 15th significant digit (~3e-16 relative, a couple of ULP) - an architecture-dependent rounding difference in the vectorized matmul, not a functional bug. Upstream hit and deselected the identical failure on manylinux_aarch64 (cms-nanoAOD/correctionlib#348).
luhenry
added a commit
that referenced
this pull request
Sep 6, 2026
304, not 302 - renumbered to avoid a collision while landing the new gotcha entry in the skill (see gotchas/test-failures-and-flakes.md).
…4/283), use -k instead
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
correctionlib2.9.0Compiles the pybind11 C++ correction-factor library CMS/particle-physics analyses use to apply calibration factors, vendoring pybind11/rapidjson/cpp-peglib/pcg-cpp/xxhash/lwtnn as submodules. Upstream publishes no riscv64 wheel.
Mirrors upstream's
wheels.yml.Differs from upstream
Testing
License: OK