Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the
CIBW_TEST_REQUIRESoverride that pinnedhypothesis<6.156.That pin was a workaround for a gap that no longer exists. hypothesis became a Rust/maturin extension at 6.156, and upstream builds riscv64
abi3-only—cp310-abi3plus acp315-abi3.abi3t— so nothing coveredcp314t(the stable free-threaded ABI starts at 3.15). On that interpreter pip fell back to the hypothesis sdist and the Rust build died computingriscv64-unknown-linux-gnu, a triple rustup does not have. That is what failed scipy'scp314tjob. We now publish hypothesis 6.165.10 for cp312/cp313/cp314/cp314t (#451), so the pin is unnecessary.The override restated upstream's
[tool.cibuildwheel] test-requiresverbatim apart from the pin, so it is deleted outright rather than unpinned in place — scipy's ownpytest pytest-xdist threadpoolctl pooch hypothesisis inherited again, and there is one less place to drift from upstream.hypothesisis added toPIP_ONLY_BINARYso resolution has to find a wheel. If our registry copy is ever missing or falls behind PyPI's latest, the job fails on "no matching distribution" instead of quietly rebuilding the sdist and failing later with a rustup error that names the wrong problem. It is inCIBW_ENVIRONMENTrather thanCIBW_TEST_ENVIRONMENTbecause that variable is already there for numpy and scipy-openblas32, and hypothesis is not a build requirement, so covering both phases costs nothing.Verified on the registry before pushing:
hypothesis-6.165.10-cp314-cp314t-manylinux_2_34_riscv64.manylinux_2_39_riscv64.whlis present, alongside cp312/cp313/cp314; and scipy 1.18.1 itself is published for all four interpreters.🤖 Generated with Claude Code