Conversation
Builds osqp-python from a checkout at the release tag with cibuildwheel, using upstream's own cibuildwheel.toml and the builtin (dependency-free) algebra backend that CMakeLists.txt already defaults to. torch has no riscv64 wheel, so testing follows upstream's own aarch64/free-threaded override that skips the osqp.nn tests. A patch adds the vendored osqp C library's NOTICE and AMD licence to the wheel's licence-files list.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
osqp1.1.3Builds the pybind11 extension that FetchContent-pulls the C
osqpsolver (builtin, dependency-free algebra backend) and links it statically. Upstream publishes no riscv64 wheel.Mirrors upstream's
build_default.yml, using its owncibuildwheel.toml.Differs from upstream
osqp.nn(torch) tests on every interpreter - torch has no riscv64 wheel, same reason upstream skips them on manylinux_aarch64.SETUPTOOLS_SCM_PRETEND_VERSION_FOR_OSQP- the licence patch dirties the tag checkout, which would otherwise poison the version.Testing
src/osqp/tests), minusnn_test.py.License: The extension statically links osqp/osqp's builtin backend, which bundles QDLDL and AMD (BSD-3-Clause); upstream's own wheels ship neither the Apache-2.0 NOTICE nor AMD's licence, so the patch adds both.
Patches
0001-package-vendored-notice-and-amd-licence.patch- To upstream, not yet submitted. Without it the wheel is missing the NOTICE/AMD licence texts Apache-2.0 and BSD-3-Clause require; reproduces on every platform, not riscv64-only.Built on cp312; full suite passed except the deselected nn tests.