Upgrade Next.js to 9 #126
Merged
Upgrade Next.js to 9 #126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically deployed with Now. Latest deployment for this branch: https://transform-git-fork-timneutkens-add-upgrade-next-9-static.ritz078.now.sh |
Brings in suggestion from vercel/next.js#7873 (comment)
Owner
|
The code is breaking on the browser. window is not defined. I ran into something similar while upgrading. |
Contributor
Author
|
@ritz078 I've added a temporary patch for the issue you saw. Tracking a full fix in vercel/next.js#8071 |
ritz078
added a commit
that referenced
this pull request
Jul 24, 2019
* remove duplicate google tag manager (#122) * Update _app.tsx (#124) * docs: add timneutkens as a contributor (#125) * docs: update README.md * docs: update .all-contributorsrc * Upgrade Next.js to 9 (#126) * Upgrade Next.js to 9 * Add back engines key * Add globalObject Brings in suggestion from vercel/next.js#7873 (comment) * Add temporary fix for window issue * fix(font): add fallback font for non mac browsers (#130) closes #129 * fix(rust): handle special characters and duplicate keys closes #97 * fix(rust): handle special chars closes #97, closes #95, closes #89, closes #62 * chore(rust): remove settings * feat(kotlin): added JSON to kotlin and json schema * fixes * fixes * fixes * fixes
ritz078
added a commit
that referenced
this pull request
Jul 24, 2019
* HTML to Pug converter (#127) * feat(pug): add HTML to pug converter * fix(pug): added package details * feat(analyze): added webpack bundle analyzer * fix(rust): handle special characters and duplicate keys (#131) * remove duplicate google tag manager (#122) * Update _app.tsx (#124) * docs: add timneutkens as a contributor (#125) * docs: update README.md * docs: update .all-contributorsrc * Upgrade Next.js to 9 (#126) * Upgrade Next.js to 9 * Add back engines key * Add globalObject Brings in suggestion from vercel/next.js#7873 (comment) * Add temporary fix for window issue * fix(font): add fallback font for non mac browsers (#130) closes #129 * fix(rust): handle special characters and duplicate keys closes #97 * fix(rust): handle special chars closes #97, closes #95, closes #89, closes #62 * chore(rust): remove settings * feat(kotlin): added JSON to kotlin and json schema * fixes * fixes * fixes * fixes * fixes * added favicon * social media tags
ritz078
added a commit
that referenced
this pull request
Jul 24, 2019
* HTML to Pug converter (#127) * feat(pug): add HTML to pug converter * fix(pug): added package details * feat(analyze): added webpack bundle analyzer * fix(rust): handle special characters and duplicate keys (#131) * remove duplicate google tag manager (#122) * Update _app.tsx (#124) * docs: add timneutkens as a contributor (#125) * docs: update README.md * docs: update .all-contributorsrc * Upgrade Next.js to 9 (#126) * Upgrade Next.js to 9 * Add back engines key * Add globalObject Brings in suggestion from vercel/next.js#7873 (comment) * Add temporary fix for window issue * fix(font): add fallback font for non mac browsers (#130) closes #129 * fix(rust): handle special characters and duplicate keys closes #97 * fix(rust): handle special chars closes #97, closes #95, closes #89, closes #62 * chore(rust): remove settings * feat(kotlin): added JSON to kotlin and json schema * fixes * fixes * fixes * fixes * fixes * added favicon * social media tags * fix(static): remove from gitignore * fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables automatic exporting, meaning that all pages will be statically exported at build time and served through the CDN automatically 🚀, it's all pages because none have
getInitialProps😌