fix: prevent infinite re-renders with unstable useRiveFile input#100
Merged
fix: prevent infinite re-renders with unstable useRiveFile input#100
Conversation
232abda to
89c925b
Compare
fb7305b to
4cc174d
Compare
Use stable inputKey derived from URI string instead of object reference as effect dependency.
120c0fc to
f24d9ef
Compare
HayesGordon
approved these changes
Jan 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
useRiveFile({uri: 'https://...'})caused infinite re-renders as the input was not stable, causing useEffect to run, which caused setResult(..), which triggered another render...Fixes #99
Note: Includes #101 (CI: ignore nitrogen copyright year changes)
Test plan
yarn testpassesyarn typecheckpassesyarn lintpassesReproducer (not checked in)