ci: ignore copyright year in nitrogen validation#101
Merged
Conversation
Simplify CI by removing duplicate validation from build-library job and adding -I flag to ignore copyright year line changes.
3 tasks
HayesGordon
approved these changes
Jan 5, 2026
mfazekas
added a commit
that referenced
this pull request
Jan 5, 2026
## Summary
- `useRiveFile({uri: 'https://...'})` caused infinite re-renders as the
input was not stable, causing useEffect to run, which caused
setResult(..), which triggered another render...
Fixes #99
**Note:** Includes #101 (CI: ignore nitrogen copyright year changes)
## Test plan
- [x] `yarn test` passes
- [x] `yarn typecheck` passes
- [x] `yarn lint` passes
<details>
<summary>Reproducer (not checked in)</summary>
```tsx
'use no memo';
import { View, StyleSheet } from 'react-native';
import { RiveView, useRiveFile, Fit } from '@rive-app/react-native';
import { useRef } from 'react';
export default function Issue99Reproducer() {
const renderCount = useRef(0);
renderCount.current++;
console.log('Issue99Reproducer render count:', renderCount.current);
// Previously this would cause infinite re-renders because inline objects
// create new references each render. Fixed by using stable inputKey in useRiveFile.
const { riveFile } = useRiveFile({
uri: 'https://cdn.rive.app/animations/vehicles.riv',
});
return (
<View style={styles.container}>
{riveFile && (
<RiveView
autoPlay={true}
fit={Fit.Contain}
file={riveFile}
onError={(error) => console.error('Rive error:', error.message)}
style={styles.rive}
/>
)}
</View>
);
}
const styles = StyleSheet.create({
container: {
flex: 1,
alignItems: 'center',
justifyContent: 'center',
},
rive: {
width: '100%',
height: '100%',
},
});
```
</details>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove duplicate nitrogen validation from build-library job and add
-Iflag to ignore copyright year line changes in generated files.