Fix various small finalized-related bugs in job listing#1327
Merged
Conversation
Fixes a few bugs related to use of finalized in job listing: * Valid finalized-only queries were rejected because the validation condition was inverted. `JoblistOrderByFinalizedAt` was unusable as documented. * Queries containing non-finalized states were accepted even though jobs would have no `finalized_at` value, making requested order meaningless. * Mixed finalized and non-finalized filters were also accepted, leading to the same problem. * Returning a non-finalized job could panic while constructing the pagination cursor because its `FinalizedAt` value is `nil`. Fixes #1326, but also squashes a couple other related bugs that Codex found while investigating.
brandur
force-pushed
the
brandur-finalized-at-list-fixes
branch
from
July 23, 2026 17:25
9f00b23 to
a6c2c37
Compare
bgentry
approved these changes
Jul 23, 2026
bgentry
left a comment
bgentry
left a comment
Contributor
There was a problem hiding this comment.
LGTM just make sure this plays nicely with riverui 🙏
Contributor
Author
|
Thx! Had Codex do a review pass on River UI and it seems to think it all checks out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a few bugs related to use of finalized in job listing:
Valid finalized-only queries were rejected because the validation
condition was inverted.
JoblistOrderByFinalizedAtwas unusable asdocumented.
Queries containing non-finalized states were accepted even though jobs
would have no
finalized_atvalue, making requested order meaningless.Mixed finalized and non-finalized filters were also accepted, leading
to the same problem.
Returning a non-finalized job could panic while constructing the
pagination cursor because its
FinalizedAtvalue isnil.Fixes #1326, but also squashes a couple other related bugs that Codex
found while investigating.