Cap retry seconds after applying jitter in case jitter brought it over limit#1023
Merged
Cap retry seconds after applying jitter in case jitter brought it over limit#1023
Conversation
…r limit Response to #1022: in the default retry policy, cap retry seconds to `maxDurationSeconds` after applying jitter just in case the application of jitter brought it over limit. This should never realistically happen due to the way exponentials work. If attempt N would bring retry seconds over `maxDurationSeconds`, then attempt N-1 will likely be nowhere near `maxDurationSeconds` and a 10% jitter won't be able to bring it over, but still, capping it really doesn't hurt, so just do it as an additional shore up. Fixes #1022.
bgentry
approved these changes
Aug 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Response to #1022: in the default retry policy, cap retry seconds to
maxDurationSecondsafter applying jitter just in case the applicationof jitter brought it over limit.
This should never realistically happen due to the way exponentials work.
If attempt N would bring retry seconds over
maxDurationSeconds, thenattempt N-1 will likely be nowhere near
maxDurationSecondsand a 10%jitter won't be able to bring it over, but still, capping it really
doesn't hurt, so just do it as an additional shore up.
Fixes #1022.