Add riverlog.LoggerSafely for access outside work body without panic
#1093
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here, add a "safe" variant of
riverlog.Logger:rigerlog.LoggerSafely.While it'd be rare to not know whether you had a logger or not from
inside a
Workfunction,Workfunctions might call into other Gomodules in your project, those modules might be reused in non-
Workcontexts, and it might not always be clear whether a logger should be
available or not.
This function lets users do a conditional check before logging:
I went with the "safely" naming according to our conventions elsewhere,
but one thing I'm not sure about is that
ClientFromContextSafelywhichis a similar function, returns an error instead of
okboolean. Here webreak with that convention somewhat, but I think the boolean version is
more ergonomic. Another option might be to give this a slightly
alternative naming convention like
LoggerOKorLoggerMaybe.Fixes #1092.