Add initTestConfig helper for more succinct example tests#1249
Merged
Conversation
Here, add an `initTestConfig` helper for example tests that wraps up a lot of the common testing logic in each. This leaves the example tests more succinct, takes a lot of test-only code out of the equation to keep the signal higher for readers, and makes broadly refactoring example tests easier as changes may need to only be made in one place. This is very similar to the change we already made in River Pro.
brandur
force-pushed
the
brandur-init-test-config
branch
from
e59fd26 to
b076e40
Compare
bgentry
approved these changes
May 11, 2026
Contributor
bgentry
left a comment
bgentry
left a comment
There was a problem hiding this comment.
I was just thinking of how useful it would be to pull this change over while I was reviewing the Resumable Jobs PR. Thank you for doing so!
Contributor
Author
|
Awesome man. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here, add an
initTestConfighelper for example tests that wraps up alot of the common testing logic in each. This leaves the example tests
more succinct, takes a lot of test-only code out of the equation to keep
the signal higher for readers, and makes broadly refactoring example
tests easier as changes may need to only be made in one place. This is
very similar to the change we already made in River Pro.