Skip to content

expose JobCancelError, JobSnoozeError#665

Merged
bgentry merged 1 commit intomasterfrom
bg-expose-error-types
Nov 3, 2024
Merged

expose JobCancelError, JobSnoozeError#665
bgentry merged 1 commit intomasterfrom
bg-expose-error-types

Conversation

@bgentry
Copy link
Copy Markdown
Contributor

@bgentry bgentry commented Nov 3, 2024

These were initially kept as unexported types, but it turns out they're useful for testing. Still, they should not be initialized directly (i.e. from within workers) and should be used through the JobCancel and JobSnooze top level functions.

Fixes #625.

@bgentry bgentry requested a review from brandur November 3, 2024 19:37
These were initially kept as unexported types, but it turns out they're
useful for testing. Still, they should not be initialized directly (i.e.
from within workers) and should be used through the `JobCancel` and
`JobSnooze` top level functions.

Fixes #625.
@bgentry bgentry force-pushed the bg-expose-error-types branch from 6348bd7 to 14ca3eb Compare November 3, 2024 19:38
@bgentry bgentry merged commit 30f09a0 into master Nov 3, 2024
@bgentry bgentry deleted the bg-expose-error-types branch November 3, 2024 19:43
tigrato pushed a commit to gravitational/river that referenced this pull request Dec 18, 2024
These were initially kept as unexported types, but it turns out they're
useful for testing. Still, they should not be initialized directly (i.e.
from within workers) and should be used through the `JobCancel` and
`JobSnooze` top level functions.

Fixes riverqueue#625.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make jobCancelError and jobSnoozeError public

1 participant