Merged
Conversation
These were initially kept as unexported types, but it turns out they're useful for testing. Still, they should not be initialized directly (i.e. from within workers) and should be used through the `JobCancel` and `JobSnooze` top level functions. Fixes #625.
6348bd7 to
14ca3eb
Compare
tigrato
pushed a commit
to gravitational/river
that referenced
this pull request
Dec 18, 2024
These were initially kept as unexported types, but it turns out they're useful for testing. Still, they should not be initialized directly (i.e. from within workers) and should be used through the `JobCancel` and `JobSnooze` top level functions. Fixes riverqueue#625.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These were initially kept as unexported types, but it turns out they're useful for testing. Still, they should not be initialized directly (i.e. from within workers) and should be used through the
JobCancelandJobSnoozetop level functions.Fixes #625.