Merged
Conversation
brandur
approved these changes
Dec 24, 2024
Contributor
brandur
left a comment
brandur
left a comment
There was a problem hiding this comment.
Yep, seems good. Maybe add changelog too for completeness.
bgentry
force-pushed
the
bg-add-line-to-migration-comment
branch
from
387ebf4 to
0914190
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When printing the pro sequence migration, I realized its comment was still:
Which is to say that it's the same no matter which line you're migrating, pro or non-pro. I thought this could be improved by adding the line name so it's instead:
Still doesn't explicitly make pro vs non-pro clear, but it's a small improvement IMO.
Will add a changelog if you agree this is a good change.