cleanly error adding queue to client w/out workers#826
Merged
Conversation
Prior to this change, calling `.Add()` on the `QueueBundle` for a `Client` which wasn't configured to run any jobs (i.e. no `Workers` configured) resulted in a panic due to a missing completer internally. This changes the behavior to cleanly error with a descriptive message instead.
bgentry
force-pushed
the
bg-bad-queue-bundle-behavior
branch
from
f3b494c to
49caf15
Compare
brandur
approved these changes
Apr 2, 2025
Contributor
brandur
left a comment
brandur
left a comment
There was a problem hiding this comment.
Ah, doh. Yeah improving the error seems like a good option for now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to this change, calling
.Add()on theQueueBundlefor aClientwhich wasn't configured to run any jobs (i.e. noWorkersconfigured) resulted in a panic due to a missing completer internally:This changes the behavior to cleanly error with a descriptive message instead. Open to any cleaner way to improve this if you have ideas! 🙏