otelriver: Add kinds span attribute to insert_many spans#62
Merged
Conversation
Emit the distinct, sorted job kinds present in each batch as a `kinds` string-slice attribute on `river.insert_many` spans. This surfaces which kinds were inserted in each batch for trace queries without affecting metric cardinality. Co-authored-by: Cursor <cursoragent@cursor.com>
echatman
force-pushed
the
add-kinds-span-attribute
branch
from
20a6fb4 to
63d595e
Compare
Merged
brandur
added a commit
that referenced
this pull request
Jun 6, 2026
Prepare release v0.10.0, including #62. I also put a few fixes into the changelog and some cosmetic alphabetization stuff. [skip ci]
Contributor
|
Released in v0.10.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
kindsstring-slice attribute onriver.insert_manyspans, so trace queries can answer "which kinds were in this batch?" without affecting metric cardinality.kindsfrommanyParamsregardless of the outcome (success, error, or panic), so it's available on everyinsert_manyspan.Test plan
kinds=["no_op"]assertion to the existingInsertManySuccess,InsertManyError, andInsertManyPanicsubtests.InsertManyMixedKindssubtest that submits a 3-job batch with 2 distinct kinds (and a duplicate) and verifies the attribute is deduplicated and sorted.go test ./otelriver/...andgo vet ./otelriver/...pass locally.Made with Cursor
Made with Cursor