more cleanly handle snoozed and retryable states#104
Merged
Conversation
brandur
approved these changes
Aug 3, 2024
brandur
added a commit
that referenced
this pull request
Aug 3, 2024
A bug fix release including the snoozed fix in #104.
Merged
brandur
added a commit
that referenced
this pull request
Aug 3, 2024
A bug fix release including the snoozed fix in #104.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #103 highlights another tricky edge case with attempting to determine job duration, in this case for snoozed jobs. Upon snoozing, it's actually not possible to determine the job's runtime from any of the data stored as of now. There's no error record with a timestamp, no
finalized_at, and no other value saved to indicate when the job stopped executing.This was actually resulting in a crashing error in the UI in this case. I fixed it by reworking some of the logic so that we focus on isolating the easy-to-detect errored case first. I added a Storybook scenario for this case, as well as one for pending, and verified that all the
JobTimelinestates look correct with realistic data.Fixes #103.