Allow setting slog handler from env var#381
Allow setting slog handler from env var#381bgentry merged 2 commits intoriverqueue:masterfrom pcriv:master
Conversation
|
@bgentry Thoughts on this one? I initially thought this was on the main project and was a little skeptical about that, but we do use quite a few env vars in the UI already so it makes more sense though. @pcriv I'm kind of thinking that if we go with this we should remove the abbreviation and use something like Ignore Docker build failures. Those builds don't work for third party contributors. |
|
Thanks for the suggestions! @brandur ofc I can update that 👍🏽 |
|
@bgentry I cleaned up the code a bit, lmk if it's better now |
bgentry
left a comment
There was a problem hiding this comment.
Much better! 🤩 Thank you.
|
Thanks to you folks! Happy to contribute just a little bit to this awesome project :) |
Simple PR to allow setting the slog Handler as a JSON handler by using the
RIVER_LOG_FORMATenv variable