Skip to content

fix workflow diagram zoom issues, style minimap#408

Merged
bgentry merged 1 commit intomasterfrom
bg-fix-workflow-diagram-zoom
Aug 23, 2025
Merged

fix workflow diagram zoom issues, style minimap#408
bgentry merged 1 commit intomasterfrom
bg-fix-workflow-diagram-zoom

Conversation

@bgentry
Copy link
Copy Markdown
Contributor

@bgentry bgentry commented Aug 21, 2025 •
edited
Loading

  • Workflow detail: prevent the viewport from getting stuck zoomed into empty space after navigating between the workflow list and detail pages by remounting the diagram per workflow and enabling fit-to-view on mount.
  • Workflow detail: make MiniMap render nodes correctly and respect dark mode by setting explicit node bounds and theme-aware colors.
Scenario Light Dark
Before Screenshot 2025-08-20 at 10 29 24 PM Screenshot 2025-08-20 at 10 29 14 PM
After Screenshot 2025-08-20 at 10 27 54 PM Screenshot 2025-08-20 at 10 28 02 PM

@bgentry bgentry requested a review from brandur August 21, 2025 03:30
@bgentry bgentry force-pushed the bg-fix-workflow-diagram-zoom branch from 44a07f0 to 144f3eb Compare August 21, 2025 03:31
brandur
brandur approved these changes Aug 23, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@brandur brandur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff!

@bgentry bgentry merged commit 5719f98 into master Aug 23, 2025
19 checks passed
@bgentry bgentry deleted the bg-fix-workflow-diagram-zoom branch August 23, 2025 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brandur brandur brandur approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bgentry @brandur