Serve robots.txt to prevent crawlers from accessing UI#97
Merged
Conversation
bgentry
reviewed
Jul 19, 2024
Contributor
bgentry
left a comment
There was a problem hiding this comment.
Do you think this makes sense in the generalized riverui handler, or should it be specific to the demo app? Open to either, just not sure if this is something regular users will want (or if it makes sense path prefixed within the handler).
b796423 to
e55c19a
Compare
robots.txt to prevent Google indexing a zillion sample jobsrobots.txt to prevent crawlers from accessing UI
e55c19a to
3bc12e0
Compare
bgentry
approved these changes
Jul 21, 2024
3bc12e0 to
9d9ad90
Compare
Collaborator
Author
|
Thx. Was going to mention too that I feel like what I ended up with here is a bit of overkill in that it allows generic files to be added along with |
Here, add a `robots.txt` that denies all crawler access to UI installations. If a River UI is exposed publicly without authentication, it's bad and a security problem, but we don't have to make it worse by allowing crawlers to find it. We'll add a separate `robots.txt` in the demo that will allow basic access to top-level pages, although deny access to crawl through the potentially tens of thousands of jobs in `/jobs/`. There were a number of ways to go about this that were plausible. I ended up putting in an embedded file system that can pull in static files easily into the Go program, and which could be reused for future static files in case they're needed. It may be a little more than we need right now, but it wasn't much harder to do than serving a one off static file.
9d9ad90 to
3ce193b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here, add a
robots.txtthat denies all crawler access to UIinstallations. If a River UI is exposed publicly without authentication,
it's bad and a security problem, but we don't have to make it worse by
allowing crawlers to find it.
We'll add a separate
robots.txtin the demo that will allow basicaccess to top-level pages, although deny access to crawl through the
potentially tens of thousands of jobs in
/jobs/.There were a number of ways to go about this that were plausible. I
ended up putting in an embedded file system that can pull in static
files easily into the Go program, and which could be reused for future
static files in case they're needed. It may be a little more than we
need right now, but it wasn't much harder to do than serving a one off
static file.