Merged
Conversation
brandur
approved these changes
Jul 25, 2024
Collaborator
brandur
left a comment
brandur
left a comment
There was a problem hiding this comment.
Awesome!
LGTM. It does look like JS Lint pushed up some at least somewhat valid critiques — worth taking a look at those?
| apiendpoint.Mount(mux, opts.Logger, &queueResumeEndpoint{apiBundle: apiBundle}) | ||
| apiendpoint.Mount(mux, opts.Logger, &stateAndCountGetEndpoint{apiBundle: apiBundle}) | ||
| apiendpoint.Mount(mux, opts.Logger, &workflowGetEndpoint{apiBundle: apiBundle}) | ||
| apiendpoint.Mount(mux, opts.Logger, &workflowListEndpoint{apiBundle: apiBundle}) |
Collaborator
There was a problem hiding this comment.
Do you want to add an "integration level" (end-to-end HTTP stack) test for the new endpoint in handler_test.go? Should be close to just a one liner.
Contributor
Author
|
Thanks, fixed both of those 🙏 |
bgentry
force-pushed
the
bg-workflow-ui-improvements
branch
from
154783d to
39a2cc2
Compare
brandur
approved these changes
Jul 25, 2024
brandur
added a commit
that referenced
this pull request
Jul 25, 2024
Prepare release v0.3.0, which largely contains workflows from #99.
brandur
added a commit
that referenced
this pull request
Jul 25, 2024
Prepare release v0.3.0, which largely contains workflows from #99.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.