Fix(guard): return error response on router error - #2540
Closed
MasterPtato wants to merge 1 commit into
Closed
Conversation
This was referenced Jun 4, 2025
Closed
Contributor
Author
There was a problem hiding this comment.
PR Summary
Modified error handling in the guard server's routing logic to return INTERNAL_SERVER_ERROR responses on routing failures instead of attempting fallback routes.
- Changed
create_routing_functioninpackages/edge/infra/guard/server/src/routing/mod.rsto immediately return errors rather than continuing with fallback routes - Improved import formatting in
packages/edge/infra/guard/server/src/routing/api.rsfor better code readability - Potential breaking change: Requests will no longer attempt alternative routing methods if the primary route fails
2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
Deploying rivet with
|
| Latest commit: |
78b6466
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://e17aecdf.rivet.pages.dev |
| Branch Preview URL: | https://06-04-fix-guard-return-error.rivet.pages.dev |
MasterPtato
force-pushed
the
06-04-fix_guard_return_error_response_on_router_error
branch
from
June 4, 2025 19:17
28067bc to
b87a3c1
Compare
This was referenced Jun 4, 2025
NathanFlurry
force-pushed
the
06-04-fix_guard_return_error_response_on_router_error
branch
from
June 5, 2025 00:58
b87a3c1 to
a2b2d0d
Compare
NathanFlurry
force-pushed
the
06-04-fix_pegboard_wait_for_actor_allocation_not_creation
branch
from
June 5, 2025 00:58
60de115 to
779cf53
Compare
Deploying rivet-studio with
|
| Latest commit: |
78b6466
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://6b97be24.rivet-studio.pages.dev |
| Branch Preview URL: | https://06-04-fix-guard-return-error.rivet-studio.pages.dev |
Deploying rivet-hub with
|
| Latest commit: |
78b6466
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://4fc93442.rivet-hub-7jb.pages.dev |
| Branch Preview URL: | https://06-04-fix-guard-return-error.rivet-hub-7jb.pages.dev |
MasterPtato
force-pushed
the
06-04-fix_pegboard_wait_for_actor_allocation_not_creation
branch
from
June 5, 2025 02:10
779cf53 to
5526790
Compare
MasterPtato
force-pushed
the
06-04-fix_guard_return_error_response_on_router_error
branch
from
June 5, 2025 02:10
a2b2d0d to
5227285
Compare
This was referenced Jun 5, 2025
Closed
MasterPtato
force-pushed
the
06-04-fix_guard_return_error_response_on_router_error
branch
from
June 6, 2025 01:36
5227285 to
bf7487c
Compare
This was referenced Jun 6, 2025
MasterPtato
force-pushed
the
06-04-fix_guard_return_error_response_on_router_error
branch
from
June 6, 2025 18:29
bf7487c to
78b6466
Compare
MasterPtato
force-pushed
the
06-04-fix_pegboard_wait_for_actor_allocation_not_creation
branch
from
June 6, 2025 18:29
6d98c23 to
d6aaade
Compare
This was referenced Jun 6, 2025
Contributor
Merge activity
|
graphite-app Bot
pushed a commit
that referenced
this pull request
Jun 9, 2025
<!-- Please make sure there is an issue that this PR is correlated to. --> ## Changes <!-- If there are frontend changes, please include screenshots. -->
graphite-app
Bot
deleted the
06-04-fix_guard_return_error_response_on_router_error
branch
June 9, 2025 16:49
This was referenced Jun 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Changes