fix(rivetkit): track serverless application listener for graceful shutdown drain - #5673
Open
Tyagiquamar wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When
registry.listen()is invoked in serverless listener mode, it startsruntime.serveListener(registry, ...). During graceful shutdown (registry.shutdown()/#drain()), the drain logic specifically includes:However,
listen()previously calledawait runtime.serveListener(...)directly without storing the returned promise intothis.#applicationListenerPromise. As a result,this.#applicationListenerPromiseremainedundefined, andshutdown()would not await or drain the active serverless listener before completing.This PR assigns
this.#applicationListenerPromise = listenerPromise;inlisten()prior to awaiting it, ensuring the active serverless listener is tracked and drained as intended during shutdown.Type of change
How Has This Been Tested?
rivetkit-typescript/packages/rivetkit/tests/registry-shutdown.test.ts(waits for in-flight serverless application listener before resolving) asserting thatshutdown()waits on the activeserveListenerpromise during drain.pnpm --filter rivetkit test tests/registry-shutdown.test.ts(all 8 tests pass).pnpm --filter rivetkit format(Biome).Checklist: