Skip to content

fix: uncomment function type filter in ACTORS_FILTER #2533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Parent: chore(examples): multitenant deploys example
wants to merge 1 commit into from
Closed

fix: uncomment function type filter in ACTORS_FILTER #2533

wants to merge 1 commit into from

Conversation

@NathanFlurry
Copy link
Member

Changes

@NathanFlurry NathanFlurry mentioned this pull request Jun 4, 2025
Closed
@NathanFlurry Graphite App
Copy link
Member Author

NathanFlurry commented Jun 4, 2025 •
edited
Loading

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

How to use the Graphite Merge Queue

Add the label merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@NathanFlurry NathanFlurry mentioned this pull request Jun 4, 2025
Closed
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jun 4, 2025 •
edited
Loading

Deploying rivet-hub with  Cloudflare Pages  Cloudflare Pages

Latest commit: dd008fa
Status:🚫  Build failed.

View logs

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jun 4, 2025 •
edited
Loading

Deploying rivet with  Cloudflare Pages  Cloudflare Pages

Latest commit: dd008fa
Status:🚫  Build failed.

View logs

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jun 4, 2025 •
edited
Loading

Deploying rivet-studio with  Cloudflare Pages  Cloudflare Pages

Latest commit: dd008fa
Status:🚫  Build failed.

View logs

@NathanFlurry NathanFlurry force-pushed the fix_uncomment_function_type_filter_in_ACTORS_FILTER branch from fcb7b6c to e90af51 Compare June 5, 2025 01:36
@NathanFlurry NathanFlurry force-pushed the 06-02-chore_examples_multitenant_deploys_example branch from 5d883a7 to 7f6788a Compare June 5, 2025 01:36
@NathanFlurry NathanFlurry mentioned this pull request Jun 5, 2025
Closed
@NathanFlurry NathanFlurry force-pushed the fix_uncomment_function_type_filter_in_ACTORS_FILTER branch from e90af51 to fba55a4 Compare June 5, 2025 04:45
@NathanFlurry NathanFlurry force-pushed the 06-02-chore_examples_multitenant_deploys_example branch from 7f6788a to abba1a0 Compare June 5, 2025 04:45
@NathanFlurry NathanFlurry mentioned this pull request Jun 5, 2025
Closed
@NathanFlurry NathanFlurry force-pushed the fix_uncomment_function_type_filter_in_ACTORS_FILTER branch from fba55a4 to d8521b4 Compare June 8, 2025 19:09
@NathanFlurry NathanFlurry force-pushed the 06-02-chore_examples_multitenant_deploys_example branch from abba1a0 to 310b649 Compare June 8, 2025 19:09
@NathanFlurry NathanFlurry mentioned this pull request Jun 8, 2025
Closed
@NathanFlurry NathanFlurry marked this pull request as ready for review June 9, 2025 09:16
@NathanFlurry NathanFlurry requested a review from MasterPtato June 9, 2025 09:16
@NathanFlurry NathanFlurry mentioned this pull request Jun 9, 2025
Closed
greptile-apps[bot]
greptile-apps bot reviewed Jun 9, 2025
View reviewed changes
Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Restores filtering logic in frontend/apps/hub/src/routes/_authenticated/_layout/projects/$projectNameId/environments/$environmentNameId._v2/containers.tsx by uncommented the function type filter in ACTORS_FILTER.

  • Fixed bug by re-enabling filter that excludes 'function' type and 'actor-core' framework actors from the containers view, ensuring only relevant actors are displayed

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

@NathanFlurry NathanFlurry force-pushed the fix_uncomment_function_type_filter_in_ACTORS_FILTER branch from d8521b4 to b7c38f4 Compare June 9, 2025 18:59
@MasterPtato MasterPtato force-pushed the 06-02-chore_examples_multitenant_deploys_example branch from 7dc5b9f to a512da3 Compare June 9, 2025 19:26
@MasterPtato MasterPtato force-pushed the fix_uncomment_function_type_filter_in_ACTORS_FILTER branch from b7c38f4 to 65e7c70 Compare June 9, 2025 19:26
This was referenced Jun 9, 2025
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Jun 16, 2025
Closed
Closed
@MasterPtato MasterPtato force-pushed the 06-02-chore_examples_multitenant_deploys_example branch from f118519 to 730d5f8 Compare June 17, 2025 00:33
@MasterPtato MasterPtato force-pushed the fix_uncomment_function_type_filter_in_ACTORS_FILTER branch from cf63a04 to 127da0d Compare June 17, 2025 00:33
This was referenced Jun 17, 2025
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@abcxff abcxff force-pushed the 06-02-chore_examples_multitenant_deploys_example branch from 730d5f8 to f2198ae Compare June 18, 2025 16:37
@abcxff abcxff force-pushed the fix_uncomment_function_type_filter_in_ACTORS_FILTER branch from 127da0d to da02915 Compare June 18, 2025 16:37
@MasterPtato MasterPtato force-pushed the 06-02-chore_examples_multitenant_deploys_example branch from f2198ae to 730d5f8 Compare June 18, 2025 23:47
@MasterPtato MasterPtato force-pushed the fix_uncomment_function_type_filter_in_ACTORS_FILTER branch from da02915 to 127da0d Compare June 18, 2025 23:47
This was referenced Jun 19, 2025
Closed
Closed
@NathanFlurry NathanFlurry force-pushed the fix_uncomment_function_type_filter_in_ACTORS_FILTER branch from 127da0d to dd008fa Compare June 20, 2025 18:54
This was referenced Jun 20, 2025
Closed
Closed
Closed
Closed
Closed
@graphite-app
Copy link
Contributor

graphite-app bot commented Jun 20, 2025 •
edited
Loading

Merge activity

  • Jun 20, 7:02 PM UTC: NathanFlurry added this pull request to the Graphite merge queue.
  • Jun 20, 7:03 PM UTC: CI is running for this pull request on a draft pull request (#2629) due to your merge queue CI optimization settings.
  • Jun 20, 7:04 PM UTC: Merged by the Graphite merge queue via draft PR: #2629.

graphite-app bot pushed a commit that referenced this pull request Jun 20, 2025
@NathanFlurry
fix: uncomment function type filter in ACTORS_FILTER (#2533)
f7d97c9 
<!-- Please make sure there is an issue that this PR is correlated to. -->

## Changes

<!-- If there are frontend changes, please include screenshots. -->
@graphite-app graphite-app bot closed this Jun 20, 2025
@graphite-app graphite-app bot deleted the fix_uncomment_function_type_filter_in_ACTORS_FILTER branch June 20, 2025 19:04
@github-actions github-actions bot mentioned this pull request Jun 20, 2025
Merged
@NathanFlurry NathanFlurry mentioned this pull request Jul 3, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MasterPtato MasterPtato Awaiting requested review from MasterPtato

1 more reviewer

@greptile-apps greptile-apps[bot] greptile-apps[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@NathanFlurry