-
Notifications
You must be signed in to change notification settings - Fork 130
chore: fix guard metrics #2504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
MasterPtato
wants to merge
1
commit into
05-30-feat_add_pb_usage_metrics_server_state
from
05-31-chore_fix_guard_metrics
Closed
chore: fix guard metrics #2504
MasterPtato
wants to merge
1
commit into
05-30-feat_add_pb_usage_metrics_server_state
from
05-31-chore_fix_guard_metrics
+38
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 31, 2025
This was referenced May 31, 2025
Closed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
Optimizes error handling and metrics recording in the Guard proxy service to prevent race conditions and ensure logical ordering of metric collection.
- Restructured metrics recording in
packages/edge/infra/guard/core/src/proxy_service.rsto capture status codes within successful request handling block - Separated error metric recording into dedicated error handling block for better isolation
- Improved request lifecycle tracking by ensuring metrics are recorded in sequential order
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
33cc1e7 to
b867000
Compare
2f17dc8 to
1eac431
Compare
1eac431 to
2f17dc8
Compare
b867000 to
ec91701
Compare
Deploying rivet with
|
| Latest commit: |
3e7664e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://8e4f31d8.rivet.pages.dev |
| Branch Preview URL: | https://05-31-chore-fix-guard-metric.rivet.pages.dev |
Deploying rivet-hub with
|
| Latest commit: |
3e7664e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://deb48fe8.rivet-hub-7jb.pages.dev |
| Branch Preview URL: | https://05-31-chore-fix-guard-metric.rivet-hub-7jb.pages.dev |
Deploying rivet-studio with
|
| Latest commit: |
3e7664e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://160e77ee.rivet-studio.pages.dev |
| Branch Preview URL: | https://05-31-chore-fix-guard-metric.rivet-studio.pages.dev |
ec91701 to
edec6dc
Compare
2f17dc8 to
1eac431
Compare
edec6dc to
be42f65
Compare
be42f65 to
3e7664e
Compare
2f17dc8 to
39fc637
Compare
3e7664e to
6d6cc7e
Compare
39fc637 to
a7ff390
Compare
This was referenced Jun 2, 2025
This was referenced Jun 3, 2025
Closed
This was referenced Jun 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

Changes