Skip to content

Conversation

@MasterPtato
Copy link
Contributor

Changes

Copy link
Contributor Author

MasterPtato commented May 31, 2025

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more


How to use the Graphite Merge Queue

Add the label merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Optimizes error handling and metrics recording in the Guard proxy service to prevent race conditions and ensure logical ordering of metric collection.

  • Restructured metrics recording in packages/edge/infra/guard/core/src/proxy_service.rs to capture status codes within successful request handling block
  • Separated error metric recording into dedicated error handling block for better isolation
  • Improved request lifecycle tracking by ensuring metrics are recorded in sequential order

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

@NathanFlurry NathanFlurry force-pushed the 05-31-chore_fix_guard_metrics branch from 33cc1e7 to b867000 Compare May 31, 2025 01:01
@NathanFlurry NathanFlurry force-pushed the 05-30-feat_add_pb_usage_metrics_server_state branch from 2f17dc8 to 1eac431 Compare May 31, 2025 01:01
@MasterPtato MasterPtato force-pushed the 05-30-feat_add_pb_usage_metrics_server_state branch from 1eac431 to 2f17dc8 Compare May 31, 2025 01:04
@MasterPtato MasterPtato force-pushed the 05-31-chore_fix_guard_metrics branch from b867000 to ec91701 Compare May 31, 2025 01:04
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented May 31, 2025

Deploying rivet with  Cloudflare Pages  Cloudflare Pages

Latest commit: 3e7664e
Status: ✅  Deploy successful!
Preview URL: https://8e4f31d8.rivet.pages.dev
Branch Preview URL: https://05-31-chore-fix-guard-metric.rivet.pages.dev

View logs

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented May 31, 2025

Deploying rivet-hub with  Cloudflare Pages  Cloudflare Pages

Latest commit: 3e7664e
Status: ✅  Deploy successful!
Preview URL: https://deb48fe8.rivet-hub-7jb.pages.dev
Branch Preview URL: https://05-31-chore-fix-guard-metric.rivet-hub-7jb.pages.dev

View logs

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented May 31, 2025

Deploying rivet-studio with  Cloudflare Pages  Cloudflare Pages

Latest commit: 3e7664e
Status: ✅  Deploy successful!
Preview URL: https://160e77ee.rivet-studio.pages.dev
Branch Preview URL: https://05-31-chore-fix-guard-metric.rivet-studio.pages.dev

View logs

@NathanFlurry NathanFlurry force-pushed the 05-31-chore_fix_guard_metrics branch from ec91701 to edec6dc Compare May 31, 2025 01:52
@NathanFlurry NathanFlurry force-pushed the 05-30-feat_add_pb_usage_metrics_server_state branch from 2f17dc8 to 1eac431 Compare May 31, 2025 01:52
@MasterPtato MasterPtato force-pushed the 05-31-chore_fix_guard_metrics branch from edec6dc to be42f65 Compare May 31, 2025 02:05
@graphite-app graphite-app bot closed this Jun 3, 2025
@graphite-app graphite-app bot deleted the 05-31-chore_fix_guard_metrics branch June 3, 2025 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant