Skip to content

Conversation

@MasterPtato
Copy link
Contributor

Changes

Copy link
Contributor Author

MasterPtato commented May 29, 2025

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more


How to use the Graphite Merge Queue

Add the label merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Modified tracing span name in packages/core/api/status/src/route/actor.rs to standardize naming conventions across the codebase.

  • Changed tracing span name from 'actor destroy request' to 'actor_destroy_request' for better consistency with underscore-based naming pattern

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented May 29, 2025

Deploying rivet with  Cloudflare Pages  Cloudflare Pages

Latest commit: 90e20fd
Status: ✅  Deploy successful!
Preview URL: https://623a407d.rivet.pages.dev
Branch Preview URL: https://05-29-fix-cache-add-traces.rivet.pages.dev

View logs

@MasterPtato MasterPtato force-pushed the 05-29-fix_cache_add_traces branch from b545b82 to c2f767d Compare May 29, 2025 21:18
@MasterPtato MasterPtato force-pushed the 05-29-fix_cache_add_traces branch 2 times, most recently from bed201b to d69ce87 Compare May 30, 2025 02:31
@NathanFlurry NathanFlurry force-pushed the 05-29-fix_cache_add_traces branch from d69ce87 to ecbaa48 Compare May 31, 2025 00:39
@NathanFlurry NathanFlurry force-pushed the 05-28-fix_guard_add_more_tokio_runtime_metrics_remove_labels_from_metrics branch from ce70387 to 08138ed Compare May 31, 2025 00:39
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented May 31, 2025

Deploying rivet-studio with  Cloudflare Pages  Cloudflare Pages

Latest commit: 90e20fd
Status: ✅  Deploy successful!
Preview URL: https://938397f2.rivet-studio.pages.dev
Branch Preview URL: https://05-29-fix-cache-add-traces.rivet-studio.pages.dev

View logs

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented May 31, 2025

Deploying rivet-hub with  Cloudflare Pages  Cloudflare Pages

Latest commit: 90e20fd
Status: ✅  Deploy successful!
Preview URL: https://87ef61e4.rivet-hub-7jb.pages.dev
Branch Preview URL: https://05-29-fix-cache-add-traces.rivet-hub-7jb.pages.dev

View logs

@MasterPtato MasterPtato force-pushed the 05-29-fix_cache_add_traces branch from ecbaa48 to 47e00c0 Compare May 31, 2025 00:54
@MasterPtato MasterPtato force-pushed the 05-28-fix_guard_add_more_tokio_runtime_metrics_remove_labels_from_metrics branch from 08138ed to f6d2ad5 Compare May 31, 2025 00:54
@MasterPtato MasterPtato requested a review from NathanFlurry May 31, 2025 00:54
@NathanFlurry NathanFlurry force-pushed the 05-29-fix_cache_add_traces branch from 47e00c0 to ecbaa48 Compare May 31, 2025 01:01
@NathanFlurry NathanFlurry force-pushed the 05-28-fix_guard_add_more_tokio_runtime_metrics_remove_labels_from_metrics branch from f6d2ad5 to 08138ed Compare May 31, 2025 01:01
@MasterPtato MasterPtato force-pushed the 05-28-fix_guard_add_more_tokio_runtime_metrics_remove_labels_from_metrics branch from 08138ed to f6d2ad5 Compare May 31, 2025 01:04
@MasterPtato MasterPtato force-pushed the 05-29-fix_cache_add_traces branch from ecbaa48 to 47e00c0 Compare May 31, 2025 01:04
@NathanFlurry NathanFlurry force-pushed the 05-29-fix_cache_add_traces branch from 47e00c0 to ecbaa48 Compare May 31, 2025 01:52
@NathanFlurry NathanFlurry force-pushed the 05-28-fix_guard_add_more_tokio_runtime_metrics_remove_labels_from_metrics branch from f6d2ad5 to 08138ed Compare May 31, 2025 01:52
@MasterPtato MasterPtato force-pushed the 05-29-fix_cache_add_traces branch from ecbaa48 to 47e00c0 Compare May 31, 2025 02:05
@MasterPtato MasterPtato force-pushed the 05-28-fix_guard_add_more_tokio_runtime_metrics_remove_labels_from_metrics branch from 08138ed to f6d2ad5 Compare May 31, 2025 02:05
@graphite-app graphite-app bot closed this Jun 3, 2025
@graphite-app graphite-app bot deleted the 05-29-fix_cache_add_traces branch June 3, 2025 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants