-
Notifications
You must be signed in to change notification settings - Fork 129
fix(cache): add traces #2489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
MasterPtato
wants to merge
1
commit into
05-28-fix_guard_add_more_tokio_runtime_metrics_remove_labels_from_metrics
from
05-29-fix_cache_add_traces
Closed
fix(cache): add traces #2489
MasterPtato
wants to merge
1
commit into
05-28-fix_guard_add_more_tokio_runtime_metrics_remove_labels_from_metrics
from
05-29-fix_cache_add_traces
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 29, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
Modified tracing span name in packages/core/api/status/src/route/actor.rs to standardize naming conventions across the codebase.
- Changed tracing span name from 'actor destroy request' to 'actor_destroy_request' for better consistency with underscore-based naming pattern
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
Deploying rivet with
|
| Latest commit: |
90e20fd
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://623a407d.rivet.pages.dev |
| Branch Preview URL: | https://05-29-fix-cache-add-traces.rivet.pages.dev |
b545b82 to
c2f767d
Compare
NathanFlurry
approved these changes
May 29, 2025
bed201b to
d69ce87
Compare
d69ce87 to
ecbaa48
Compare
ce70387 to
08138ed
Compare
Deploying rivet-studio with
|
| Latest commit: |
90e20fd
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://938397f2.rivet-studio.pages.dev |
| Branch Preview URL: | https://05-29-fix-cache-add-traces.rivet-studio.pages.dev |
Deploying rivet-hub with
|
| Latest commit: |
90e20fd
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://87ef61e4.rivet-hub-7jb.pages.dev |
| Branch Preview URL: | https://05-29-fix-cache-add-traces.rivet-hub-7jb.pages.dev |
ecbaa48 to
47e00c0
Compare
08138ed to
f6d2ad5
Compare
47e00c0 to
ecbaa48
Compare
f6d2ad5 to
08138ed
Compare
08138ed to
f6d2ad5
Compare
ecbaa48 to
47e00c0
Compare
47e00c0 to
ecbaa48
Compare
f6d2ad5 to
08138ed
Compare
ecbaa48 to
47e00c0
Compare
08138ed to
f6d2ad5
Compare
This was referenced Jun 3, 2025
Closed
This was referenced Jun 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

Changes