Skip to content

Conversation

@abcxff
Copy link
Contributor

@abcxff abcxff commented Jun 12, 2025

Fixes RVT-4788

@abcxff abcxff marked this pull request as ready for review June 12, 2025 03:17
Copy link
Contributor Author

abcxff commented Jun 12, 2025

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more


How to use the Graphite Merge Queue

Add the label merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@abcxff abcxff requested a review from NathanFlurry June 12, 2025 03:17
Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Implements remote build logs functionality by centralizing actor logging in the toolchain library and adding build status tracking for both Docker and Rivet builds.

  • Moved actor logging from CLI to toolchain library (packages/toolchain/toolchain/src/util/actor/logs.rs) with new exit_on_ctrl_c control
  • Added runner-specific build status tracking in CI manager including new RunnerSchema types for rivet, docker, and noRunner
  • Enhanced kaniko-runner.ts with build status validation and noRunner data support
  • Improved build monitoring in build_remote.rs by replacing static attempt counter with time-based timeout
  • Centralized base64 dependency in toolchain package for log encoding/decoding

13 files reviewed, 2 comments
Edit PR Review Bot Settings | Greptile

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jun 12, 2025

Deploying rivet with  Cloudflare Pages  Cloudflare Pages

Latest commit: 1e67e85
Status:🚫  Build failed.

View logs

@linear
Copy link

linear bot commented Jun 12, 2025

@abcxff abcxff force-pushed the 06-11-feat_toolchain_remote_build_logs branch from bcf92bd to 494b927 Compare June 12, 2025 22:52
@abcxff
Copy link
Contributor Author

abcxff commented Jun 12, 2025

@greptileai

@abcxff abcxff changed the base branch from 06-11-feat_toolchain_build_args_support_for_remote_builds to graphite-base/2587 June 13, 2025 17:12
@abcxff abcxff force-pushed the graphite-base/2587 branch from fbbfba0 to b90675b Compare June 16, 2025 18:10
@abcxff abcxff force-pushed the 06-11-feat_toolchain_remote_build_logs branch from 494b927 to 1e67e85 Compare June 16, 2025 18:10
@abcxff abcxff changed the base branch from graphite-base/2587 to 06-11-feat_toolchain_build_args_support_for_remote_builds June 16, 2025 18:10
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jun 16, 2025

Deploying rivet-hub with  Cloudflare Pages  Cloudflare Pages

Latest commit: 1e67e85
Status:🚫  Build failed.

View logs

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jun 16, 2025

Deploying rivet-studio with  Cloudflare Pages  Cloudflare Pages

Latest commit: 1e67e85
Status:🚫  Build failed.

View logs

@abcxff abcxff changed the base branch from 06-11-feat_toolchain_build_args_support_for_remote_builds to graphite-base/2587 June 18, 2025 16:37
@abcxff abcxff changed the base branch from graphite-base/2587 to 06-11-feat_toolchain_build_args_support_for_remote_builds June 18, 2025 16:41
@graphite-app
Copy link
Contributor

graphite-app bot commented Jun 20, 2025

Merge activity

  • Jun 20, 7:23 PM UTC: NathanFlurry added this pull request to the Graphite merge queue.
  • Jun 20, 7:24 PM UTC: CI is running for this pull request on a draft pull request (#2631) due to your merge queue CI optimization settings.
  • Jun 20, 7:24 PM UTC: Merged by the Graphite merge queue via draft PR: #2631.

graphite-app bot pushed a commit that referenced this pull request Jun 20, 2025
@graphite-app graphite-app bot closed this Jun 20, 2025
@graphite-app graphite-app bot deleted the 06-11-feat_toolchain_remote_build_logs branch June 20, 2025 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant