chore(pegboard): fix local cache bugs #2596
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 13, 2025
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
How to use the Graphite Merge QueueAdd the label merge-queue to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Implements multiple reliability and debugging improvements across Pegboard's local infrastructure components, focusing on error handling and test stability.
- Enhanced error context in
packages/edge/infra/client/manager/src/actor/setup.rsfor CNI network setup failures - Fixed SQL syntax bug in
packages/edge/infra/client/manager/src/image_download_handler.rsfor image download completion tracking - Improved logging configuration in
packages/edge/infra/client/manager/src/main.rswith granular control through environment variables - Added graceful filesystem error handling in
packages/edge/infra/client/manager/src/utils/mod.rsfor production resilience - Optimized test reliability in lifecycle tests by adjusting timeouts and removing redundant operations
7 files reviewed, 1 comment
Edit PR Review Bot Settings | Greptile
|
|
||
| if let Ok(filter) = std::env::var(env_var) { | ||
| for s in filter.split(',').filter(|x| !x.is_empty()) { | ||
| env_filter = env_filter.add_directive(s.parse().expect("invalid env filter")); |
There was a problem hiding this comment.
style: Consider using parse().map_err() instead of expect() to provide a more graceful error handling path for invalid filter directives
Deploying rivet with
|
| Latest commit: |
07bd21d
|
| Status: | 🚫 Build failed. |
MasterPtato
force-pushed
the
06-13-fix_cluster_fix_pbi_autoscaling
branch
from
5fff3fc to
799de6e
Compare
MasterPtato
force-pushed
the
06-13-chore_pegboard_fix_local_cache_bugs
branch
from
77cf8d1 to
7e81f73
Compare
Deploying rivet-hub with
|
| Latest commit: |
07bd21d
|
| Status: | 🚫 Build failed. |
Deploying rivet-studio with
|
| Latest commit: |
8c26d5c
|
| Status: | ⚡️ Build in progress... |
NathanFlurry
force-pushed
the
06-13-chore_pegboard_fix_local_cache_bugs
branch
from
7e81f73 to
1238c2e
Compare
NathanFlurry
force-pushed
the
06-13-fix_cluster_fix_pbi_autoscaling
branch
from
799de6e to
0129a3b
Compare
This was referenced Jun 15, 2025
MasterPtato
force-pushed
the
06-13-chore_pegboard_fix_local_cache_bugs
branch
from
94f713e to
07bd21d
Compare
MasterPtato
force-pushed
the
06-13-fix_cluster_fix_pbi_autoscaling
branch
from
58853a8 to
3ea0668
Compare
This was referenced Jun 19, 2025
NathanFlurry
force-pushed
the
06-13-chore_pegboard_fix_local_cache_bugs
branch
from
07bd21d to
1238c2e
Compare
NathanFlurry
force-pushed
the
06-13-fix_cluster_fix_pbi_autoscaling
branch
from
3ea0668 to
0129a3b
Compare
This was referenced Jun 20, 2025
MasterPtato
force-pushed
the
06-13-fix_cluster_fix_pbi_autoscaling
branch
from
0129a3b to
db249f9
Compare
MasterPtato
force-pushed
the
06-13-chore_pegboard_fix_local_cache_bugs
branch
from
1238c2e to
8c26d5c
Compare
NathanFlurry
force-pushed
the
06-13-fix_cluster_fix_pbi_autoscaling
branch
from
db249f9 to
c3bb942
Compare
NathanFlurry
force-pushed
the
06-13-chore_pegboard_fix_local_cache_bugs
branch
from
8c26d5c to
310907d
Compare
Merge activity
|
graphite-app bot
pushed a commit
that referenced
this pull request
Jun 20, 2025
<!-- Please make sure there is an issue that this PR is correlated to. --> ## Changes <!-- If there are frontend changes, please include screenshots. -->
This was referenced Jun 20, 2025
Closed
This was referenced Jun 28, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes