feat(toolchain): build args support for remote builds #2583

abcxff · 2025-06-11T22:12:04Z

Changes

RVT-4787

abcxff · 2025-06-11T22:12:16Z

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

feat(examples): multitenant using remote builds #2619
fix(toolchain): creating ci env no longer fails first try #2618
feat(toolchain): Implement dockerignore for remote builds #2590
feat(toolchain): remote build logs #2587
feat(toolchain): build args support for remote builds #2583 👈 (View in Graphite)
feat(toolchain): remote build method #2579 : 1 other dependent PR (#2601 )
fix(api): handle wrapped operation errors #2602
chore(pegboard): fix local cache bugs #2596
fix(cluster): fix pbi autoscaling #2592
feat(pegboard): add local image cache and overlay fs mounts #2586
chore(guard): fix log levels #2580
feat: db sh for workflows #2570
fix(pegboard): fix enabling root users #2572
main

How to use the Graphite Merge Queue

Add the label merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

cloudflare-workers-and-pages · 2025-06-11T22:21:05Z

Deploying rivet with Cloudflare Pages

Latest commit:	`b90675b`
Status:	🚫 Build failed.

View logs

NathanFlurry

serialize args on rust side
implement target

greptile-apps

PR Summary

Adds Docker build argument support for remote builds in Rivet's CI system, enabling dynamic configuration during build time through multiple components.

Added new cloud/packages/ci-manager/src/common.ts with utility functions for handling build argument escaping and conversion
Introduced cloud/packages/ci-runner/entry.sh to safely process build arguments using UNIT_SEP_CHAR (0x1F) delimiter
Modified cloud/packages/ci-manager/src/types.ts to add required buildArgs: Record<string, string> to BuildInfo interface
Enhanced /builds endpoint in cloud/packages/ci-manager/src/server.ts with validation for build argument format and sanitization
Updated Kaniko execution in Docker and Rivet executors to properly handle space-containing build arguments

_{9 files reviewed, 7 comments}
_{Edit PR Review Bot Settings | Greptile}

cloud/packages/ci-runner/Dockerfile

cloud/packages/ci-manager/src/types.ts

packages/toolchain/toolchain/src/util/docker/build_remote.rs

cloud/packages/ci-runner/Dockerfile

cloud/packages/ci-manager/src/executors/docker.ts

cloud/packages/ci-runner/entry.sh

cloud/packages/ci-manager/src/server.ts

cloud/packages/ci-runner/entry.sh

packages/toolchain/toolchain/src/util/docker/build_remote.rs

cloudflare-workers-and-pages · 2025-06-13T17:12:28Z

Deploying rivet-studio with Cloudflare Pages

Latest commit:	`b90675b`
Status:	🚫 Build failed.

View logs

cloudflare-workers-and-pages · 2025-06-13T17:14:00Z

Deploying rivet-hub with Cloudflare Pages

Latest commit:	`b90675b`
Status:	🚫 Build failed.

View logs

graphite-app · 2025-06-18T16:40:20Z

cloud/packages/ci-manager/src/common.ts

+		`--destination=${args.destination}`,
+		`--upload-tar=${args.outputUrl}`,
+		`--dockerfile=${args.dockerfilePath}`,
+		...(args.buildTarget ? [`--target='${args.buildTarget}'`] : []),


The --target argument should not include single quotes around the value. This will cause the quotes to be passed literally to the Docker build process, which will fail to find the target.

Change:

...(args.buildTarget ? [`--target='${args.buildTarget}'`] : []),

To:

...(args.buildTarget ? [`--target=${args.buildTarget}`] : []),

Suggested change

...(args.buildTarget ? [`--target='${args.buildTarget}'`] : []),

...(args.buildTarget ? [`--target=${args.buildTarget}`] : []),

Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.

graphite-app · 2025-06-20T19:23:02Z

Merge activity

Jun 20, 7:23 PM UTC: NathanFlurry added this pull request to the Graphite merge queue.
Jun 20, 7:24 PM UTC: CI is running for this pull request on a draft pull request (#2631) due to your merge queue CI optimization settings.
Jun 20, 7:24 PM UTC: Merged by the Graphite merge queue via draft PR: #2631.

## Changes RVT-4787

abcxff mentioned this pull request Jun 11, 2025

feat(toolchain): remote build method #2579

Closed

abcxff requested a review from NathanFlurry June 11, 2025 23:02

NathanFlurry requested changes Jun 11, 2025

View reviewed changes

abcxff requested a review from NathanFlurry June 11, 2025 23:36

abcxff marked this pull request as ready for review June 11, 2025 23:38

greptile-apps bot reviewed Jun 11, 2025

View reviewed changes

abcxff force-pushed the 06-11-feat_toolchain_build_args_support_for_remote_builds branch from 55281e5 to c2676b7 Compare June 12, 2025 00:13

NathanFlurry requested changes Jun 12, 2025

View reviewed changes

cloud/packages/ci-manager/src/server.ts Outdated Show resolved Hide resolved

cloud/packages/ci-runner/entry.sh Outdated Show resolved Hide resolved

packages/toolchain/toolchain/src/util/docker/build_remote.rs Outdated Show resolved Hide resolved

abcxff force-pushed the 06-11-feat_toolchain_build_args_support_for_remote_builds branch 2 times, most recently from 8675015 to fbbfba0 Compare June 12, 2025 02:06

abcxff requested a review from NathanFlurry June 12, 2025 02:07

NathanFlurry approved these changes Jun 12, 2025

View reviewed changes

abcxff mentioned this pull request Jun 12, 2025

feat(toolchain): remote build logs #2587

Closed

abcxff changed the base branch from 06-09-feat_toolchain_remote_build_method to graphite-base/2583 June 12, 2025 22:52

abcxff changed the base branch from graphite-base/2583 to 06-09-feat_toolchain_remote_build_method June 13, 2025 17:13

abcxff mentioned this pull request Jun 13, 2025

feat(toolchain): Implement dockerignore for remote builds #2590

Closed

NathanFlurry changed the base branch from 06-09-feat_toolchain_remote_build_method to graphite-base/2583 June 13, 2025 22:41

abcxff changed the base branch from graphite-base/2583 to 06-09-feat_toolchain_remote_build_method June 18, 2025 16:38

graphite-app bot reviewed Jun 18, 2025

View reviewed changes

MasterPtato changed the base branch from 06-09-feat_toolchain_remote_build_method to graphite-base/2583 June 18, 2025 23:46

This was referenced Jun 19, 2025

fix: figure out actor log shipping #2622

Closed

fix: get new actors working on docker compose #2623

Closed

graphite-app bot closed this Jun 20, 2025

graphite-app bot deleted the 06-11-feat_toolchain_build_args_support_for_remote_builds branch June 20, 2025 19:24

github-actions bot mentioned this pull request Jun 20, 2025

chore(main): release 25.5.1 #2423

Merged

NathanFlurry mentioned this pull request Jun 20, 2025

chore: fix merge conflicts #2634

Closed

This was referenced Jun 20, 2025

fix: add udp ports to docker compose #2635

Closed

feat: get multi actors working e2e on docker compose #2637

Closed

feat: add actor kv to runners #2638

Closed

feat: add actor queue #2644

Closed

fix: fix logs for new actors #2649

Closed

This was referenced Jun 28, 2025

fix(guard): use intercom_address for guard service discovery #2663

Closed

feat(actors): expose container system metrics #2664

Closed

chore: cargo fmt #2665

Closed

	...(args.buildTarget ? [`--target='${args.buildTarget}'`] : []),
	...(args.buildTarget ? [`--target=${args.buildTarget}`] : []),

feat(toolchain): build args support for remote builds #2583

feat(toolchain): build args support for remote builds #2583

Uh oh!

Conversation

abcxff commented Jun 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Uh oh!

abcxff commented Jun 11, 2025 • edited by NathanFlurry Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

cloudflare-workers-and-pages bot commented Jun 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Deploying rivet with Cloudflare Pages

Uh oh!

NathanFlurry left a comment

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

PR Summary

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cloudflare-workers-and-pages bot commented Jun 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Deploying rivet-studio with Cloudflare Pages

Uh oh!

cloudflare-workers-and-pages bot commented Jun 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Deploying rivet-hub with Cloudflare Pages

Uh oh!

graphite-app bot Jun 18, 2025

Choose a reason for hiding this comment

Uh oh!

graphite-app bot commented Jun 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

abcxff commented Jun 11, 2025 •

edited

Loading

abcxff commented Jun 11, 2025 •

edited by NathanFlurry

Loading

cloudflare-workers-and-pages bot commented Jun 11, 2025 •

edited

Loading

cloudflare-workers-and-pages bot commented Jun 13, 2025 •

edited

Loading

cloudflare-workers-and-pages bot commented Jun 13, 2025 •

edited

Loading

graphite-app bot commented Jun 20, 2025 •

edited

Loading