-
Notifications
You must be signed in to change notification settings - Fork 129
chore(pegboard): send artifact image size from workflow instead of fetching with HEAD #2612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 15, 2025
This was referenced Jun 15, 2025
cf74852 to
ace3f4c
Compare
496b946 to
4668010
Compare
This was referenced Jun 17, 2025
This was referenced Jun 17, 2025
| pub artifact_url_stub: String, | ||
| /// Direct S3 url to download the image from without ATS. | ||
| pub fallback_artifact_url: Option<String>, | ||
| /// Size in bytes of the artfiact. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a typo in the documentation comment: artfiact should be spelled artifact.
Suggested change
| /// Size in bytes of the artfiact. | |
| /// Size in bytes of the artifact. |
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
ace3f4c to
cf74852
Compare
4668010 to
496b946
Compare
This was referenced Jun 20, 2025
cf74852 to
fad23d9
Compare
496b946 to
bc3f03f
Compare
bc3f03f to
e24ecf7
Compare
Merge activity
|
graphite-app bot
pushed a commit
that referenced
this pull request
Jun 20, 2025
…tching with HEAD (#2612) <!-- Please make sure there is an issue that this PR is correlated to. --> ## Changes <!-- If there are frontend changes, please include screenshots. -->
This was referenced Jun 20, 2025
Closed
This was referenced Jun 28, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

Changes