Skip to content

chore: replace hub-embed with proxy to 127.0.0.1:5080 for /ui/ path in dev #2615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Parent: feat: add frontend-hub service to docker-compose
wants to merge 1 commit into from
Closed

chore: replace hub-embed with proxy to 127.0.0.1:5080 for /ui/ path in dev #2615

wants to merge 1 commit into from

Conversation

@NathanFlurry
Copy link
Member

Changes

This was referenced Jun 15, 2025
Closed
Closed
Closed
Closed
Closed
@NathanFlurry Graphite App
Copy link
Member Author

NathanFlurry commented Jun 15, 2025 •
edited
Loading

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

How to use the Graphite Merge Queue

Add the label merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@NathanFlurry NathanFlurry mentioned this pull request Jun 15, 2025
Closed
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jun 15, 2025 •
edited
Loading

Deploying rivet-studio with  Cloudflare Pages  Cloudflare Pages

Latest commit: 681fbc8
Status:🚫  Build failed.

View logs

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jun 15, 2025 •
edited
Loading

Deploying rivet-hub with  Cloudflare Pages  Cloudflare Pages

Latest commit: 681fbc8
Status: ✅  Deploy successful!
Preview URL: https://2ffecf6d.rivet-hub-7jb.pages.dev
Branch Preview URL: https://06-15-chore-replace-hub-embe.rivet-hub-7jb.pages.dev

View logs

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jun 15, 2025 •
edited
Loading

Deploying rivet with  Cloudflare Pages  Cloudflare Pages

Latest commit: 681fbc8
Status: ✅  Deploy successful!
Preview URL: https://689c174d.rivet.pages.dev
Branch Preview URL: https://06-15-chore-replace-hub-embe.rivet.pages.dev

View logs

@NathanFlurry NathanFlurry mentioned this pull request Jun 16, 2025
Closed
@MasterPtato MasterPtato force-pushed the feat_add_frontend-hub_service_to_docker-compose branch from b748722 to 764c812 Compare June 17, 2025 00:33
@MasterPtato MasterPtato force-pushed the 06-15-chore_replace_hub-embed_with_proxy_to_127.0.0.1_5080_for__ui__path_in_dev branch from 681fbc8 to 3d3a7be Compare June 17, 2025 00:33
This was referenced Jun 17, 2025
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@MasterPtato MasterPtato marked this pull request as ready for review June 20, 2025 00:59
@MasterPtato MasterPtato mentioned this pull request Jun 20, 2025
Closed
graphite-app[bot]
graphite-app bot reviewed Jun 20, 2025
View reviewed changes
packages/common/config/src/config/server/rivet/mod.rs
///
/// If disabled, the UI can be hosted separately.
pub enable: Option<bool>,
/// Origin to proxy UI requests to. This should be the server serving the actula files fro the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a typo in the documentation comment: actula files fro the should be actual files from the.

Suggested change
/// Origin to proxy UI requests to. This should be the server serving the actula files fro the
/// Origin to proxy UI requests to. This should be the server serving the actual files from the

Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.

@NathanFlurry NathanFlurry force-pushed the feat_add_frontend-hub_service_to_docker-compose branch from 764c812 to b748722 Compare June 20, 2025 18:54
@NathanFlurry NathanFlurry force-pushed the 06-15-chore_replace_hub-embed_with_proxy_to_127.0.0.1_5080_for__ui__path_in_dev branch from 3d3a7be to 681fbc8 Compare June 20, 2025 18:54
@NathanFlurry NathanFlurry mentioned this pull request Jun 20, 2025
Closed
This was referenced Jun 20, 2025
Closed
Closed
Closed
Closed
@MasterPtato MasterPtato force-pushed the 06-15-chore_replace_hub-embed_with_proxy_to_127.0.0.1_5080_for__ui__path_in_dev branch from 681fbc8 to 696dc22 Compare June 20, 2025 19:09
@MasterPtato MasterPtato force-pushed the feat_add_frontend-hub_service_to_docker-compose branch from b748722 to 3f7cb67 Compare June 20, 2025 19:09
@NathanFlurry NathanFlurry force-pushed the feat_add_frontend-hub_service_to_docker-compose branch from 3f7cb67 to 274f283 Compare June 20, 2025 19:18
@NathanFlurry NathanFlurry force-pushed the 06-15-chore_replace_hub-embed_with_proxy_to_127.0.0.1_5080_for__ui__path_in_dev branch from 696dc22 to 97e3ac2 Compare June 20, 2025 19:18
@graphite-app
Copy link
Contributor

graphite-app bot commented Jun 20, 2025 •
edited
Loading

Merge activity

  • Jun 20, 7:19 PM UTC: MasterPtato added this pull request to the Graphite merge queue.
  • Jun 20, 7:21 PM UTC: CI is running for this pull request on a draft pull request (#2630) due to your merge queue CI optimization settings.
  • Jun 20, 7:22 PM UTC: Merged by the Graphite merge queue via draft PR: #2630.

graphite-app bot pushed a commit that referenced this pull request Jun 20, 2025
@NathanFlurry
chore: replace hub-embed with proxy to 127.0.0.1:5080 for /ui/ path…
7e7c582 
… in dev (#2615)

<!-- Please make sure there is an issue that this PR is correlated to. -->

## Changes

<!-- If there are frontend changes, please include screenshots. -->
@graphite-app graphite-app bot closed this Jun 20, 2025
@graphite-app graphite-app bot deleted the 06-15-chore_replace_hub-embed_with_proxy_to_127.0.0.1_5080_for__ui__path_in_dev branch June 20, 2025 19:22
@github-actions github-actions bot mentioned this pull request Jun 20, 2025
Merged
@NathanFlurry NathanFlurry mentioned this pull request Jun 20, 2025
Closed
This was referenced Jun 20, 2025
Closed
Closed
Closed
Closed
Closed
This was referenced Jun 28, 2025
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@graphite-app graphite-app[bot] graphite-app[bot] left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@NathanFlurry