fix(config): allow configuring topo dcs via map, fix pg ssl mode config#4456
Conversation
|
🚅 Deployed to the rivet-pr-4456 environment in rivet-frontend
|
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
CLAUDE.mdImportant Domain InformationALWAYS use
The ALWAYS use Never modify an existing published
CommandsBuild Commands# Build all packages in the workspace
cargo build
# Build a specific package
cargo build -p package-name
# Build with release optimizations
cargo build --releaseTest Commands# Run all tests in the workspace
cargo test
# Run tests for a specific package
cargo test -p package-name
# Run a specific test
cargo test test_name
# Run tests with output displayed
cargo test -- --nocaptureDevelopment Commands# Format code (enforced by pre-commit hooks)
# cargo fmt
# DO NOT RUN CARGO FMT AUTOMATICALLY (note for humans: we need to run cargo fmt when everything is merged together and make sure lefthook is working)
# Run linter and fix issues
./scripts/cargo/fix.sh
# Check for linting issues
cargo clippy -- -W warningsDocker Development Environment# Start the development environment with all services
cd docker/dev
docker-compose up -dGit Commands# Use conventional commits with a single-line commit message, no co-author
git commit -m "chore(my-pkg): foo bar"Never push to Dependency Managementpnpm Workspace
SQLite Package
RivetKit Package ResolutionsThe root {
"resolutions": {
"rivetkit": "workspace:*",
"@rivetkit/react": "workspace:*",
"@rivetkit/workflow-engine": "workspace:*",
// ... other @rivetkit/* packages
}
}When adding RivetKit dependencies to examples in {
"dependencies": {
"rivetkit": "*",
"@rivetkit/react": "*"
}
}If you need to add a new Rust DependenciesDocumentation
Code Blocks in Docs
Content FrontmatterDocs (
|
PR ReviewSummary: Two focused fixes -- allow configuring topology datacenters via a hashmap (with backward-compatible list support) and fix the PostgreSQL SSL mode configuration. The Bug: Inverted SSL behavior (breaking change)File: The SSL logic has been inverted in a breaking way. Before: SSL only when Any existing deployment without let pool = if ssl_disabled {
pool_config.create_pool(Some(Runtime::Tokio1), tokio_postgres::NoTls)...
} else if let Some(config) = &config.ssl_config {
// build TLS config from explicit cert paths
...
} else {
pool_config.create_pool(Some(Runtime::Tokio1), tokio_postgres::NoTls)...
};Bug: DSN-format connection strings not handled for SSL checkFile:
Bug: Test helper sets
|
f301f2d to
f07072d
Compare

Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context.
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Checklist: