fix(cache): clean up lib#4457
fix(cache): clean up lib#4457MasterPtato wants to merge 1 commit into03-18-fix_config_allow_configuring_topo_dcs_via_map_fix_pg_ssl_mode_configfrom
Conversation
|
🚅 Deployed to the rivet-pr-4457 environment in rivet-frontend
|
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Code ReviewGood cleanup PR overall. Removing the unimplemented Redis driver and the unused rate-limiting code reduces surface area, and the double-serialization layer simplification in fetch_all_convert is a clear improvement. IssuesUnnecessary clone in delete (driver.rs:211) get and set were both updated to use self.cache directly, but delete was missed - it still does Redundant RawCacheKey conversions in purge (req_config.rs:225-255) process_key now returns RawCacheKey instead of String, but purge still has two conversion steps that are now no-ops via the blanket From for T impl:
Both can be simplified or the two intermediate vectors collapsed into one. Silent 10x capacity increase (inner.rs) Default capacity changed from 1000 to 10000 with no comment. This could meaningfully increase memory usage in constrained environments. Worth a brief comment explaining the rationale. Nits
|

Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context.
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Checklist: