chore(rivetkit): remove inline tests

[NathanFlurry]

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context.

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes

[NathanFlurry]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• chore(rivetkit): remove inline tests #4668 👈 (View in Graphite)
• fix(guard): serialize gateway actor keys correctly #4655
• fix(api): subscribe before namespace workflow dispatch #4654
• fix(rivetkit): restore hibernatable sockets and hydrate serverless starts #4658
• fix(rivetkit-native): expose full hibernation metadata to JS #4657
• fix(pegboard): persist and replay hibernating requests #4656
• fix(rivetkit): keep internal error exposure behavior consistent #4661
• test(rivetkit): stabilize actor db driver tests #4664
• fix(test): stabilize lifecycle, sleep, queue, and run edge cases #4660 : 1 other dependent PR (#4665 )
• test(rivetkit): re-enable gateway URL and direct-registry coverage #4659
• fix(rivetkit): add lifecycle error retry and gateway HTTP routing #4666
• chore(engine): publish engine bases in ci #4649 : 2 other dependent PRs (#4650 , #4652 )
• chore: lockfile lefthook #4647
• fix(rivetkit): surface native sqlite kv errors to callers #4645
• fix(rivetkit): prevent sleep races during disconnect and db work #4644
• fix(rivetkit): isolate engine envoys and propagate startup failures #4643
• test(rivetkit): remove wasm sqlite-only fixtures and coverage #4642
• chore(sqlite-vfs): remove wasm sqlite packages and workspace wiring #4641
• chore(rivetkit): remove wasm sqlite runtime #4614
• fix(sqlite-native): restore native startup kv preload #4639
• fix(sqlite-native): delete metadata before chunk range #4638
• fix(sqlite-native): keep truncate cache coherent #4637
• fix(sqlite-vfs): use delete range for truncate cleanup #4636
• fix(sqlite-native): restore kv error hook #4635
• perf(sqlite-native): avoid cloning cached read chunks #4634
• perf(sqlite-native): gate kv operation labels #4633
• perf(sqlite-native): reuse read cache for partial writes #4632
• perf(sqlite-native): remove delete file existence probe #4631
• fix(sqlite-native): gate native read cache behind env var #4630
• fix(pegboard): isolate runner config dc lookup failures #4625 : 1 other dependent PR (#4626 )
• docs(pegboard): note runner config upsert split write risk #4624
• fix(pegboard): unpack global runner config keys correctly #4623
• fix(pegboard-gateway): enforce tunnel message state #4622
• fix(pegboard-runner): clear terminal tunnel routes #4621
• fix(pegboard): skip protocol version keys in runner pool backfill #4620
• fix(pegboard): create missing normal runner configs #4619
• fix(epoxy): reuse cached optimistic value #4618
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[claude]

PR Review: chore(rivetkit): remove inline tests

Overview

This PR removes the inline client test abstraction from the RivetKit driver test suite (~2,675 lines deleted). The inline client was an alternative to the HTTP client routing calls through in-process handlers rather than over the network.

Key deletions:

• test-inline-client-driver.ts -- inline transport proxying calls to /.test/inline-driver/ endpoints
• fixtures inline-client.ts + inlineClientActor -- fixture actor for inter-actor call tests
• tests/actor-inline-client.ts -- tests for c.client() inter-actor communication
• src/sandbox/actor.test.ts -- unit test for sandbox direct URL access
• tests/agent-os-session-lifecycle.test.ts -- agentOS lifecycle tests (writeFile/readFile/exec)
• ClientType concept and the outer per-clientType loop in runDriverTests

---

Code Quality

The simplification is clean. Removing the clientType branching from DriverTestConfig, SkipTests, and setupDriverTest reduces complexity meaningfully. The indentation fix in hibernatable-websocket-protocol.ts is purely cosmetic.

---

Concerns

1. Coverage gap: inter-actor c.client() API

The deleted actor-inline-client.ts was the only test suite exercising the c.client() API (calling other actors from inside an actor action). If not covered elsewhere this is a meaningful regression. Please point to where it is tested, or add coverage back to the driver test matrix.

2. Deleted standalone test files

tests/agent-os-session-lifecycle.test.ts tested writeFile, readFile, and exec on the agentOS actor. src/sandbox/actor.test.ts tested getSandboxUrl and the destroy-then-access error path. If neither is covered by the driver test matrix their deletion drops coverage entirely.

3. Strengthened assertions in request-access.ts

The tests now always assert hasRequest === true. The removed comment noted that the file system driver does not have a request for inline connections. Fine since inline is gone, but worth documenting for future driver authors.

The actor-queue.ts change to always assert structured error codes is a clean test strengthening.

4. Breaking public interface change

clientTypes and skip.inline are removed from DriverTestConfig and SkipTests. Downstream driver configurations referencing these fields will get type errors. Worth noting in the PR description.

---

Summary

The simplification is well-executed. The main question before merging is whether c.client() inter-actor calls and the agentOS/sandbox lifecycle behaviors have coverage elsewhere. If not, consider porting minimal smoke tests for those paths directly into the driver test matrix.

No blocking issues outside the coverage question.

Generated with Claude Code