Skip to content

chore: move rivetkit to task model#4680

Draft
NathanFlurry wants to merge 1 commit into04-16-chore_rivetkit_to_rustfrom
04-19-chore_move_rivetkit_to_task_model
Draft

chore: move rivetkit to task model#4680
NathanFlurry wants to merge 1 commit into04-16-chore_rivetkit_to_rustfrom
04-19-chore_move_rivetkit_to_task_model

Conversation

@NathanFlurry
Copy link
Copy Markdown
Member

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@railway-app
Copy link
Copy Markdown

railway-app bot commented Apr 20, 2026

🚅 Deployed to the rivet-pr-4680 environment in rivet-frontend

Service Status Web Updated (UTC)
website 😴 Sleeping (View Logs) Web Apr 20, 2026 at 6:18 am
frontend-cloud ❌ Build Failed (View Logs) Web Apr 20, 2026 at 12:09 am
frontend-inspector ❌ Build Failed (View Logs) Web Apr 20, 2026 at 12:09 am
mcp-hub ✅ Success (View Logs) Web Apr 20, 2026 at 12:09 am
ladle ❌ Build Failed (View Logs) Web Apr 20, 2026 at 12:09 am
kitchen-sink ❌ Build Failed (View Logs) Web Apr 20, 2026 at 12:08 am

Copy link
Copy Markdown
Member Author

NathanFlurry commented Apr 20, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@NathanFlurry NathanFlurry mentioned this pull request Apr 20, 2026
11 tasks
@claude
Copy link
Copy Markdown

claude bot commented Apr 20, 2026

PR Review: chore: move rivetkit to task model (Draft, 3 files changed +345/-1496).

OVERVIEW: Replaces the RivetKit Rust SDK PRD and progress log with a new rivetkit-core Actor Lifecycle task-model PRD. Drops rivetkit, rivetkit-client, serde_cbor, tokio-test from Cargo.lock. No Rust source files modified.

CARGO.LOCK: Clean dependency removals. One concern: rustls-native-certs 0.8.3 is dropped for two packages. CLAUDE.md requires enabling BOTH rustls-tls-native-roots AND rustls-tls-webpki-roots together. Verify the affected crates are not still TLS-dependent (native-only breaks on Distroless/Alpine).

PRD (27 new stories, all passes:false): Well-scoped to rivetkit-core + minimal envoy-client glue only, correctly excluding rivetkit-napi and TS. Each story anchors TS parity to feat/sqlite-vfs-v2 with line numbers. Bounded channel design (US-023) and ActivityDirty coalescing (US-021) are solid fits for the channel model.

Minor concerns in PRD:

  1. US-019/US-020 (mutate_state re-entrance): in_on_state_change AtomicBool is checked before taking the write lock, which is a TOCTOU window. Two concurrent mutate_state callers could both read false before either sets it. Set the flag inside the write lock, or use the write lock itself as the re-entrance gate.
  2. US-012 (priority 12) references lifecycle_command_inbox_capacity config fields added by US-003 (priority 3). Numeric ordering looks correct but confirm execution order does not swap these.
  3. US-027: cargo clippy -- -W warnings is an acceptance criterion. Per CLAUDE.md, fix.sh and auto-format should not run automatically. Ensure the story does not trigger auto-format.

PROGRESS LOG: Truncation of ~500 lines of learnings from prior stories is intentional. Most patterns (BARE key layouts, N-API callback ordering) are already captured in CLAUDE.md.

SUMMARY: Well-scoped planning PR. Verify rustls-native-certs removal does not break TLS for any remaining crates. The in_on_state_change TOCTOU in US-020 is the one design concern worth addressing before implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant