Skip to content

chore: move code#4713

Open
MasterPtato wants to merge 1 commit into04-22-fix_gas_add_large_txn_retries_for_pulling_signals_tighten_commit_interval_for_actorsfrom
04-23-chore_move_code
Open

chore: move code#4713
MasterPtato wants to merge 1 commit into04-22-fix_gas_add_large_txn_retries_for_pulling_signals_tighten_commit_interval_for_actorsfrom
04-23-chore_move_code

Conversation

@MasterPtato
Copy link
Copy Markdown
Contributor

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@railway-app
Copy link
Copy Markdown

railway-app Bot commented Apr 23, 2026

🚅 Deployed to the rivet-pr-4713 environment in rivet-frontend

Service Status Web Updated (UTC)
kitchen-sink ❌ Build Failed (View Logs) Web Apr 25, 2026 at 1:08 am
frontend-cloud 😴 Sleeping (View Logs) Web Apr 24, 2026 at 12:01 am
website 😴 Sleeping (View Logs) Web Apr 23, 2026 at 11:56 pm
mcp-hub ✅ Success (View Logs) Web Apr 23, 2026 at 11:50 pm
frontend-inspector ❌ Build Failed (View Logs) Web Apr 23, 2026 at 11:50 pm
ladle ❌ Build Failed (View Logs) Web Apr 23, 2026 at 11:50 pm

@claude
Copy link
Copy Markdown

claude Bot commented Apr 23, 2026

PR Review: "chore: move code"

Summary

Three files changed (+5/-13). Two independent refactors: a timestamp capture fix in ping.rs and a config-computation encapsulation in ping_task.rs.


Correctness — ping.rs

The ping.rs change has real behavioral significance beyond what "move code" implies.

FDB transaction closures passed to .run(|tx| async move { ... }) are retried on conflict. Previously, util::timestamp::now() was called inside the closure, so each retry wrote a different timestamp to LastPingTsKey. By capturing now before the closure, the timestamp is stable across retries and correctly represents when the ping measurement was taken, not when the transaction finally committed.

Suggestion: Update the PR description or add a brief comment noting the retry-stability motivation, so future readers understand this is not a purely mechanical move.


Encapsulation — ping_task.rs

Moving Duration::from_millis(ctx.config().pegboard().runner_update_ping_interval_ms()) into ping_task::task() is a clean simplification. The config is already accessible via ctx, the call site loses one parameter, and behavior is identical. No concerns.


Convention Checks

Check Result
Logging (tracing, no eprintln!) Pass
Concurrency (no Mutex<HashMap>) Pass
Error handling (anyhow + .context()) Pass
Commit message (conventional commits) Pass
No docs/limits drift N/A

CI Note

The CI failures visible on this PR (Railway deploys for kitchen-sink, frontend-inspector, ladle) appear to be pre-existing frontend issues unrelated to the Rust changes here.


Verdict

Changes are correct and convention-compliant. The one actionable item is clarifying the correctness motivation for the ping.rs timestamp capture in the PR description or a code comment.

@MasterPtato MasterPtato force-pushed the 04-23-chore_move_code branch from db1b306 to a696272 Compare April 24, 2026 18:20
@MasterPtato MasterPtato force-pushed the 04-22-fix_gas_add_large_txn_retries_for_pulling_signals_tighten_commit_interval_for_actors branch from cd88cb0 to a50d021 Compare April 24, 2026 18:20
@MasterPtato MasterPtato force-pushed the 04-23-chore_move_code branch from a696272 to 741b7d4 Compare April 24, 2026 23:02
@MasterPtato MasterPtato force-pushed the 04-22-fix_gas_add_large_txn_retries_for_pulling_signals_tighten_commit_interval_for_actors branch from a50d021 to 5d39087 Compare April 24, 2026 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant