fix: update railway docs to include graceful shutdown#4715
fix: update railway docs to include graceful shutdown#4715MasterPtato wants to merge 1 commit into04-23-fix_add_wf_registry_commandfrom
Conversation
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
PR Review: fix: update railway docs to include graceful shutdownThis PR adds a "Graceful Shutdown" section to the Railway self-hosting docs. The intent is correct and valuable, but there are a few issues to address before merging. Critical: Wrong recommended grace periodThe new section recommends 60 seconds as a grace period. Every other doc in the repo specifies 130 seconds:
The 130-second floor exists because the runner waits up to 120 seconds for actors to drain (plus a ~10-second buffer). A 60-second drain window will silently truncate actor draining on every deploy, defeating the purpose of this feature. Fix: Update all three CLAUDE.md violation: Em dashesCLAUDE.md explicitly states: "Do not use em dashes (—). Use periods to separate sentences instead." Two em dashes appear in the new content:
These need to be rewritten using periods or restructured sentences. Clarity: PID 1 guidance should specify which service it targetsA Railway project from this guide has two services: the Rivet Engine (Step 2, Minor: Section placementThe forward-reference at Step 2 points to a "Graceful Shutdown" section that appears after Step 3. Readers following numbered steps will be directed to a section they haven't reached yet. Consider moving the shutdown section before Step 3 or embedding it as a sub-step under Step 2. What looks correct
|
dfd9202 to
b4e1f50
Compare
db7f54d to
df97819
Compare
b4e1f50 to
39b3555
Compare
39b3555 to
2daf067
Compare
df97819 to
3ff43a4
Compare
2daf067 to
f8853a2
Compare
3ff43a4 to
0a19554
Compare

Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context.
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Checklist: