Skip to content

docs(driver-tests): repair progress tracker#4893

Closed
NathanFlurry wants to merge 1 commit intodriver-test-complaints/drop-vitest-filterfrom
driver-test-complaints/repair-progress-note
Closed

docs(driver-tests): repair progress tracker#4893
NathanFlurry wants to merge 1 commit intodriver-test-complaints/drop-vitest-filterfrom
driver-test-complaints/repair-progress-note

Conversation

@NathanFlurry
Copy link
Copy Markdown
Member

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Copy link
Copy Markdown
Member Author

NathanFlurry commented May 3, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@claude
Copy link
Copy Markdown
Contributor

claude Bot commented May 3, 2026

Code Review: docs(driver-tests): repair progress tracker

Overview

This PR resolves a raw git merge conflict that was left unresolved in .agent/notes/driver-test-progress.md (the conflict markers <<<<<<< HEAD / ======= / >>>>>>> were still present in the file) and expands the tracker to cover both native (NAPI) and wasm runtimes with a cleaner, more structured format.

What Changed

  • Merge conflict resolved: Removes the unresolved conflict markers from the old DB-only tracking session.
  • Dual-runtime coverage: Each row now shows [native] [wasm] status, giving a cleaner cross-runtime picture.
  • Fast/Slow/Excluded split: Useful categorization that aligns with how the driver-test-runner skill instructs tests to be run.
  • Final summary section: Good addition — provides a quick snapshot of overall pass rates and maps failing groups to their root cause (remote-SQLite exec stubs vs. actual bugs).
  • Notes section: Documents the three fixes applied during the run and links to .agent/notes/driver-test-complaints.md for the prioritized issue list.

Observations

Minor inconsistency in hibernatable-websocket-protocol row:

- [-] [ ] hibernatable-websocket-protocol | ...

The second column is [ ] (not run) while the Final Summary reports 1/2 fail for native. The wasm column being blank is fine if wasm was never attempted, but it would be clearer to annotate it like other wasm-skipped rows (e.g. [-] with a parenthetical reason) so future runs don't misread [ ] as "pending."

Log section is truncated: Only 6 entries appear after the reformat. The old log had granular per-test timestamps useful for tracing regressions across sessions. If the intent is to keep the log lightweight going forward that is fine, but worth being intentional since .agent/notes/driver-test-progress.md is referenced by the driver-test-runner skill to track state across agent runs.

actor-sleep-db placement: It appears only under Slow Tests now (removed from Fast Tests), which is the correct categorization. Worth confirming the skill's ## Fast Tests section parsing (per CLAUDE.md: "pass only the files listed under ## Fast Tests") is not affected by the removal.

Summary

Clean, well-motivated doc fix. The main nit is the hibernatable-websocket-protocol wasm column inconsistency — [ ] vs [-] is ambiguous when the test was intentionally not run. Everything else looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant