chroe: rename rivetkit-sqlite to depot-client

[NathanFlurry]

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context.

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes

[NathanFlurry]

• chore(driver-test-runner): add native/wasm runtime matrix to skill #4884 : 4 dependent PRs (#4892 , #4894 , #4896 and 1 other)
• chroe: rename rivetkit-sqlite to depot-client #4883 👈 (View in Graphite)
• fix(rivetkit-wasm): fix mem leaks #4880
• chore(rivetkit): wasm support #4860
• feat(sqlite): add cold read benchmarks and simplify optimizations #4857
• feat(sqlite): benchmark cold reads #4848 : 1 other dependent PR (#4864 )
• docs(actors): document manual lifecycle controls #4847
• test(sqlite): expand db stress coverage #4846 : 1 other dependent PR (#4849 )
• test(raw-websocket): add serverless smoke coverage #4845
• feat(serverless): configure drain grace period #4844
• fix(publish): enable frontend build for engine target and use turbo build instead of turbo build:engine #4843
• feat(rivetkit): expose conn handle in onWebSocket context #4842
• fix(rivetkit): normalize waitUntil/keepAwake promises to null to avoid serde undefined error #4841
• fix(rivetkit): remove requirement for token #4839 : 1 other dependent PR (#4840 )
• fix(pegboard-envoy): allow sqlite requests across lifecycle states #4838
• fix(pegboard): route scoped actor key reads by runner dc #4837
• fix(sqlite-storage): let sqlite open take over stale owners #4834
• fix(engine-tests): parallelize multi-DC startup + enable 6 multi-DC tests #4833
• fix(api): honor cursor in actor_ids list path #4832
• fix(api): silently filter invalid IDs from actor_ids query instead of 400 #4831
• fix(api-peer): make actors_delete idempotent for already-destroyed actors #4830
• fix(pegboard): use Iterator streaming mode in list_names so limit param is honored #4829
• chore(engine-tests): convert envoy tests to Sleep crash policy + triage ignored #4828
• feat(engine-tests): wire envoy actor names through prepopulate_actor_names #4827
• chore(depot): fault injection tests #4868
• feat(sqlite): pitr & forking #4859 : 1 other dependent PR (#4863 )
• chore(sqlite): stateless storage refactor #4856
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[claude]

Code Review: chore rename rivetkit-sqlite to depot-client

Overview:
This PR renames the rivetkit-sqlite / rivetkit-sqlite-types crates to depot-client / depot-client-types and relocates them from rivetkit-rust/packages/ to engine/packages/. The change is largely mechanical — Cargo manifests, workspace references, import paths, the wasm-gate script, and internal docs all updated consistently.

---

Issues

1. Test deletion without replacement (high concern)

rivetkit-rust/packages/rivetkit-sqlite/tests/remote_execution_parity.rs is deleted outright (261 lines, 3 test cases) and is not present anywhere in the new engine/packages/depot-client/tests/ tree:

• remote_migration_order_persists_across_reopen
• remote_execute_write_forces_writer_for_readonly_sql
• remote_manual_transactions_stay_on_writer_until_commit_or_rollback

These cover important correctness invariants for migration persistence, writer enforcement for read-only SQL, and manual transaction routing. They used open_database_from_engine, which appears to have been renamed to open_database_from_envoy, but the tests themselves should be updated and carried over, not dropped. If they are deliberately removed because they are now covered elsewhere, that should be called out explicitly in the PR description.

2. Undocumented API change mixed into a rename PR

Every VFS registration and context-build call in the test files gains a new None argument in multiple sites (vfs.rs, scenario.rs, etc.). Based on the CLAUDE.md update (CompactionSignaler) this appears to be an optional compaction signaler wired into the VFS layer. That is a behavioural change beyond a rename and should be documented in the PR description, with the new parameter type and purpose made explicit. Passing None everywhere in tests also means the new code path is never exercised under test.

---

Minor

• Commit message typo: Title reads "chroe:" instead of "chore:".
• AGENTS.md symlink scope: A symlink was correctly added at engine/packages/depot-client/tests/inline/fault/AGENTS.md. If a top-level engine/packages/depot-client/CLAUDE.md exists, it also needs its own AGENTS.md sibling per the CLAUDE.md convention.
• PR description is template boilerplate with unchecked checklist. It would help reviewers to know: (a) why the package moves to engine/packages/, (b) what the new None parameter represents, (c) whether the deleted tests are intentionally dropped or need to be ported.

---

What looks good

• All workspace dependency references, feature flags (sqlite-local, wasm ban list), and internal doc links updated consistently with no dangling rivetkit-sqlite references left behind.
• docs-internal/engine/sqlite-vfs.md correctly collapses the now-irrelevant native vs WASM parity section.
• Formatting fixes (split concatenated lines in VFS tests) are clean.
• depot/CLAUDE.md test-location bullet updated correctly.

---

Summary

The mechanical rename is clean and complete. Two items to resolve before merging: (1) the deleted remote execution parity tests need to be ported to engine/packages/depot-client/tests/ with the updated open_database_from_envoy API, and (2) the new optional CompactionSignaler parameter should be documented and at least one test site should exercise it with a real signaler.