Skip to content

fix(rivetkit): persist native onSleep state on errors #4936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NathanFlurry merged 1 commit into from
May 5, 2026
+13 −10
Merged

fix(rivetkit): persist native onSleep state on errors #4936

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 13 additions & 10 deletions rivetkit-typescript/packages/rivetkit/src/registry/native.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3950,16 +3950,19 @@ export function buildNativeFactory(
const actorCtx = makeActorCtx(ctx);
try {
if (onSleep) {
await onSleep(actorCtx);
if (runtime.kind === "wasm") {
// Wasm cannot use the native context save helper here because
// the runtime owns the serialized state handoff.
await runtime.actorSaveState(
ctx,
actorCtx.serializeForTick("save"),
);
} else {
await actorCtx.saveState({ immediate: true });
try {
await onSleep(actorCtx);
} finally {
if (runtime.kind === "wasm") {
// Wasm cannot use the native context save helper here because
// the runtime owns the serialized state handoff.
await runtime.actorSaveState(
ctx,
actorCtx.serializeForTick("save"),
);
} else {
await actorCtx.saveState({ immediate: true });
}
}
}
} finally {
Expand Down
Loading