fix(rivetkit): persist native onSleep state on errors

[NathanFlurry]

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context.

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes

[NathanFlurry]

• fix(pegboard): align drain grace defaults with stop threshold #4958 : 2 dependent PRs (#4960 , #4966 )
• fix(rivetkit): preserve bridge error messages #4959
• fix(rivetkit): fire abort signal on shutdown finalize #4957
• fix(rivetkit): use startup kv preload #4956
• fix(client): flatten skipReadyWait option #4955
• ci(publish): add manual preview publish flow #4954
• fix(depot): add ltx decode diagnostics #4953
• fix(universaldb): preserve plain set values #4952
• fix(universaldb): align versionstamp operand encoding #4951
• fix(rivetkit): export database provider types #4950
• wip: kitchen sink agentic loop finish #4949
• chore(rivetkit): note duplicate admission logic #4948
• test(rivetkit): cover bypass fetch header forwarding #4947
• feat(kitchen-sink): add actor probe controls #4946
• fix(gateway): split actor response wait errors #4945
• fix(guard): handle bypass preflight before query parse #4944
• feat(kitchen-sink): add mock agent event log copy #4943
• fix(kitchen-sink): default mock agent to local endpoint #4942
• test(rivetkit): enable driver lifecycle regressions #4941
• test(rivetkit): verify cached websocket db refs exceed grace #4940
• fix(rivetkit-core): keep sleeping actors reachable during grace #4939
• test(rivetkit): cover async websocket close db access #4938
• fix(rivetkit): keep actors awake until keepAwake work finishes #4937
• fix(rivetkit): persist native onSleep state on errors #4936 👈 (View in Graphite)
• fix(rivetkit-core): allow dispatch during sleep grace #4935
• fix(rivetkit): make duplicate sleep requests idempotent #4934
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[claude]

Code Review: fix(rivetkit): persist native onSleep state on errors

Overview

This PR fixes a bug where actor state was not persisted when the onSleep callback threw an error. The fix wraps onSleep(actorCtx) in a try/finally block so the state save runs unconditionally, even on error.

---

Correctness

The fix is sound. Previously, a thrown exception in onSleep would skip the save path and fall through to the outer finally (database close, state clear, dispose), leaving state un-persisted before sleep. The try/finally restructure is the correct pattern here.

One subtle risk: if onSleep throws and the subsequent saveState/actorSaveState in the finally block also throws, the original onSleep error is silently discarded. This is inherent to JS try/finally semantics and is likely acceptable (a save failure is more actionable), but worth noting.

---

Consistency with Other Lifecycle Hooks

• onDestroy does not save state (correct, since a destroyed actor needs no persistence).
• onBeforeActorStart disposes in a finally but does not save state.
• onSleep is the only lifecycle hook where a post-callback state persist is meaningful, so the asymmetry is intentional.

---

Code Quality

Minimal and well-scoped. The existing outer finally block for cleanup (closeDatabase, clearNativeRuntimeState, dispose) is left intact, and the inner try/finally nests cleanly within it.

---

Test Coverage

No test verifies that state persists when onSleep throws. A driver test would strengthen this fix: have onSleep throw after mutating state, then verify the state is correct when the actor re-wakes.

---

Summary

Category	Assessment
Correctness	Correct fix for the described bug
Risk	Low - minimal, well-contained change
Test coverage	Missing; a regression test is recommended
Style/conventions	Consistent with surrounding code

The fix is correct. Recommend adding a test to guard the error-path behavior.

[github-actions]

Preview packages published to npm

Install with:

npm install rivetkit@pr-4936

All packages published as 0.0.0-pr.4936.fa84f39 with tag pr-4936.

Engine binary is shipped via @rivetkit/engine-cli on linux-x64-musl, linux-arm64-musl, darwin-x64, and darwin-arm64. Windows users should use the release installer or set RIVET_ENGINE_BINARY.

Docker images:

docker pull rivetdev/engine:slim-fa84f39
docker pull rivetdev/engine:full-fa84f39

Individual packages

npm install rivetkit@pr-4936
npm install @rivetkit/react@pr-4936
npm install @rivetkit/rivetkit-napi@pr-4936
npm install @rivetkit/workflow-engine@pr-4936